mirror of https://github.com/torvalds/linux.git
292a089d78
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown". After a timer is set to this state, then it can no
longer be re-armed.
The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed. It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.
This was created by using a coccinelle script and the following
commands:
$ cat timer.cocci
@@
expression ptr, slab;
identifier timer, rfield;
@@
(
- del_timer(&ptr->timer);
+ timer_shutdown(&ptr->timer);
|
- del_timer_sync(&ptr->timer);
+ timer_shutdown_sync(&ptr->timer);
)
... when strict
when != ptr->timer
(
kfree_rcu(ptr, rfield);
|
kmem_cache_free(slab, ptr);
|
kfree(ptr);
)
$ spatch timer.cocci . > /tmp/t.patch
$ patch -p1 < /tmp/t.patch
Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| alps.c | ||
| alps.h | ||
| amimouse.c | ||
| appletouch.c | ||
| atarimouse.c | ||
| bcm5974.c | ||
| byd.c | ||
| byd.h | ||
| cyapa.c | ||
| cyapa.h | ||
| cyapa_gen3.c | ||
| cyapa_gen5.c | ||
| cyapa_gen6.c | ||
| cypress_ps2.c | ||
| cypress_ps2.h | ||
| elan_i2c.h | ||
| elan_i2c_core.c | ||
| elan_i2c_i2c.c | ||
| elan_i2c_smbus.c | ||
| elantech.c | ||
| elantech.h | ||
| focaltech.c | ||
| focaltech.h | ||
| gpio_mouse.c | ||
| hgpk.c | ||
| hgpk.h | ||
| inport.c | ||
| lifebook.c | ||
| lifebook.h | ||
| logibm.c | ||
| logips2pp.c | ||
| logips2pp.h | ||
| maplemouse.c | ||
| navpoint.c | ||
| pc110pad.c | ||
| psmouse-base.c | ||
| psmouse-smbus.c | ||
| psmouse.h | ||
| pxa930_trkball.c | ||
| rpcmouse.c | ||
| sentelic.c | ||
| sentelic.h | ||
| sermouse.c | ||
| synaptics.c | ||
| synaptics.h | ||
| synaptics_i2c.c | ||
| synaptics_usb.c | ||
| touchkit_ps2.c | ||
| touchkit_ps2.h | ||
| trackpoint.c | ||
| trackpoint.h | ||
| vmmouse.c | ||
| vmmouse.h | ||
| vsxxxaa.c | ||