mirror of https://github.com/torvalds/linux.git
a1efdaba2d
Currently reset methods are not specified directly in the ata_port_operations table. If a LLD wants to use custom reset methods, it should construct and use a error_handler which uses those reset methods. It's done this way for two reasons. First, the ops table already contained too many methods and adding four more of them would noticeably increase the amount of necessary boilerplate code all over low level drivers. Second, as ->error_handler uses those reset methods, it can get confusing. ie. By overriding ->error_handler, those reset ops can be made useless making layering a bit hazy. Now that ops table uses inheritance, the first problem doesn't exist anymore. The second isn't completely solved but is relieved by providing default values - most drivers can just override what it has implemented and don't have to concern itself about higher level callbacks. In fact, there currently is no driver which actually modifies error handling behavior. Drivers which override ->error_handler just wraps the standard error handler only to prepare the controller for EH. I don't think making ops layering strict has any noticeable benefit. This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and their PMP counterparts propoer ops. Default ops are provided in the base ops tables and drivers are converted to override individual reset methods instead of creating custom error_handler. * ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs aren't accessible. sata_promise doesn't need to use separate error_handlers for PATA and SATA anymore. * softreset is broken for sata_inic162x and sata_sx4. As libata now always prefers hardreset, this doesn't really matter but the ops are forced to NULL using ATA_OP_NULL for documentation purpose. * pata_hpt374 needs to use different prereset for the first and second PCI functions. This used to be done by branching from hpt374_error_handler(). The proper way to do this is to use separate ops and port_info tables for each function. Converted. Signed-off-by: Tejun Heo <htejun@gmail.com> |
||
|---|---|---|
| .. | ||
| aacraid | ||
| aic7xxx | ||
| aic7xxx_old | ||
| aic94xx | ||
| arcmsr | ||
| arm | ||
| dpt | ||
| ibmvscsi | ||
| libsas | ||
| lpfc | ||
| megaraid | ||
| pcmcia | ||
| qla2xxx | ||
| qla4xxx | ||
| sym53c8xx_2 | ||
| .gitignore | ||
| 3w-9xxx.c | ||
| 3w-9xxx.h | ||
| 3w-xxxx.c | ||
| 3w-xxxx.h | ||
| 53c700.c | ||
| 53c700.h | ||
| 53c700.scr | ||
| 53c700_d.h_shipped | ||
| BusLogic.c | ||
| BusLogic.h | ||
| FlashPoint.c | ||
| Kconfig | ||
| Makefile | ||
| NCR53c406a.c | ||
| NCR5380.c | ||
| NCR5380.h | ||
| NCR_D700.c | ||
| NCR_D700.h | ||
| NCR_Q720.c | ||
| NCR_Q720.h | ||
| a100u2w.c | ||
| a100u2w.h | ||
| a2091.c | ||
| a2091.h | ||
| a3000.c | ||
| a3000.h | ||
| a4000t.c | ||
| advansys.c | ||
| aha152x.c | ||
| aha152x.h | ||
| aha1542.c | ||
| aha1542.h | ||
| aha1740.c | ||
| aha1740.h | ||
| aic7xxx_old.c | ||
| atari_NCR5380.c | ||
| atari_dma_emul.c | ||
| atari_scsi.c | ||
| atari_scsi.h | ||
| atp870u.c | ||
| atp870u.h | ||
| bvme6000_scsi.c | ||
| ch.c | ||
| constants.c | ||
| dc395x.c | ||
| dc395x.h | ||
| dmx3191d.c | ||
| dpt_i2o.c | ||
| dpti.h | ||
| dtc.c | ||
| dtc.h | ||
| eata.c | ||
| eata_generic.h | ||
| eata_pio.c | ||
| eata_pio.h | ||
| esp_scsi.c | ||
| esp_scsi.h | ||
| fd_mcs.c | ||
| fdomain.c | ||
| fdomain.h | ||
| g_NCR5380.c | ||
| g_NCR5380.h | ||
| g_NCR5380_mmio.c | ||
| gdth.c | ||
| gdth.h | ||
| gdth_ioctl.h | ||
| gdth_proc.c | ||
| gdth_proc.h | ||
| gvp11.c | ||
| gvp11.h | ||
| hosts.c | ||
| hptiop.c | ||
| hptiop.h | ||
| ibmmca.c | ||
| ide-scsi.c | ||
| imm.c | ||
| imm.h | ||
| in2000.c | ||
| in2000.h | ||
| initio.c | ||
| initio.h | ||
| ipr.c | ||
| ipr.h | ||
| ips.c | ||
| ips.h | ||
| iscsi_tcp.c | ||
| iscsi_tcp.h | ||
| jazz_esp.c | ||
| lasi700.c | ||
| libiscsi.c | ||
| libsrp.c | ||
| mac53c94.c | ||
| mac53c94.h | ||
| mac_scsi.c | ||
| mac_scsi.h | ||
| megaraid.c | ||
| megaraid.h | ||
| mesh.c | ||
| mesh.h | ||
| mvme16x_scsi.c | ||
| mvme147.c | ||
| mvme147.h | ||
| mvsas.c | ||
| ncr53c8xx.c | ||
| ncr53c8xx.h | ||
| nsp32.c | ||
| nsp32.h | ||
| nsp32_debug.c | ||
| nsp32_io.h | ||
| osst.c | ||
| osst.h | ||
| osst_detect.h | ||
| osst_options.h | ||
| pas16.c | ||
| pas16.h | ||
| ppa.c | ||
| ppa.h | ||
| ps3rom.c | ||
| ql1040_fw.h | ||
| ql1280_fw.h | ||
| ql12160_fw.h | ||
| qla1280.c | ||
| qla1280.h | ||
| qlogicfas.c | ||
| qlogicfas408.c | ||
| qlogicfas408.h | ||
| qlogicpti.c | ||
| qlogicpti.h | ||
| qlogicpti_asm.c | ||
| raid_class.c | ||
| script_asm.pl | ||
| scsi.c | ||
| scsi.h | ||
| scsi_debug.c | ||
| scsi_debug.h | ||
| scsi_devinfo.c | ||
| scsi_error.c | ||
| scsi_ioctl.c | ||
| scsi_lib.c | ||
| scsi_lib_dma.c | ||
| scsi_logging.h | ||
| scsi_module.c | ||
| scsi_netlink.c | ||
| scsi_priv.h | ||
| scsi_proc.c | ||
| scsi_sas_internal.h | ||
| scsi_scan.c | ||
| scsi_sysctl.c | ||
| scsi_sysfs.c | ||
| scsi_tgt_if.c | ||
| scsi_tgt_lib.c | ||
| scsi_tgt_priv.h | ||
| scsi_transport_api.h | ||
| scsi_transport_fc.c | ||
| scsi_transport_fc_internal.h | ||
| scsi_transport_iscsi.c | ||
| scsi_transport_sas.c | ||
| scsi_transport_spi.c | ||
| scsi_transport_srp.c | ||
| scsi_transport_srp_internal.h | ||
| scsi_typedefs.h | ||
| scsi_wait_scan.c | ||
| scsicam.c | ||
| sd.c | ||
| ses.c | ||
| sg.c | ||
| sgiwd93.c | ||
| sim710.c | ||
| sni_53c710.c | ||
| sr.c | ||
| sr.h | ||
| sr_ioctl.c | ||
| sr_vendor.c | ||
| st.c | ||
| st.h | ||
| st_options.h | ||
| stex.c | ||
| sun3_NCR5380.c | ||
| sun3_scsi.c | ||
| sun3_scsi.h | ||
| sun3_scsi_vme.c | ||
| sun3x_esp.c | ||
| sun_esp.c | ||
| sym53c416.c | ||
| sym53c416.h | ||
| t128.c | ||
| t128.h | ||
| tmscsim.c | ||
| tmscsim.h | ||
| u14-34f.c | ||
| ultrastor.c | ||
| ultrastor.h | ||
| wd33c93.c | ||
| wd33c93.h | ||
| wd7000.c | ||
| zalon.c | ||
| zorro7xx.c | ||