linux/drivers
Ben Hutchings 89b12faba4 3c59x: Fix deadlock in vortex_error()
This fixes a bug introduced in commit
de84727214
"3c59x: Use fine-grained locks for MII and windowed register access".

vortex_interrupt() holds vp->window_lock over multiple register
accesses to reduce locking overhead.  However it also needs to call
vortex_error() sometimes, and that uses the regular functions for
access to windowed registers, which will try to acquire window_lock
again.

Therefore, drop window_lock around the call to vortex_error() and set
the window afterward reacquiring the lock.  Since vortex_error() may
call vortex_rx(), which *does* require its caller to hold window_lock,
lift that call up into vortex_interrupt().  This also removes the
potential for calling vortex_rx() on a later-generation NIC.

Reported-and-tested-by: Jens Schüßler <jgs@trash.net> [in Debian's 2.6.32]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-09-07 13:57:22 -07:00
..
accessibility
acpi
amba
ata
atm solos-pci: Fix race condition in tasklet RX handling 2010-08-07 23:02:59 -07:00
auxdisplay
base
block
bluetooth
cdrom
char ppp: make channel_ops const 2010-08-04 21:53:17 -07:00
clocksource
connector
cpufreq
cpuidle
crypto
dca
dio
dma
edac
eisa
firewire
firmware
gpio
gpu
hid
hwmon
i2c
ide
idle
ieee1394
ieee802154
infiniband
input
isdn isdn/avm: fix build when PCMCIA is not enabled 2010-08-22 21:37:33 -07:00
leds
lguest
macintosh
mca
md
media
memstick
message
mfd
misc
mmc
mtd
net 3c59x: Fix deadlock in vortex_error() 2010-09-07 13:57:22 -07:00
nubus
of
oprofile
parisc
parport
pci
pcmcia
platform
pnp
power
pps
ps3
rapidio
regulator
rtc
s390 ctcm: rename READ/WRITE defines to avoid redefinitions 2010-08-12 16:04:23 -07:00
sbus
scsi
serial
sfi
sh
sn
spi
ssb
staging
tc
telephony
thermal
uio
usb
uwb
vhost vhost: stop worker only if created 2010-09-01 14:26:13 -07:00
video
virtio
vlynq
w1
watchdog
xen
zorro
Kconfig
Makefile