mirror of https://github.com/torvalds/linux.git
02cdb02cea
Josh proposed the following change, and I don't think I could
explain it any better than he did:
From: Josh Durgin <josh.durgin@inktank.com>
Date: Tue, 24 Jul 2012 14:22:11 -0700
To: ceph-devel <ceph-devel@vger.kernel.org>
Message-ID: <500F1203.9050605@inktank.com>
Right now the kernel still has one piece of rbd management
duplicated from the rbd command line tool: snapshot creation.
There's nothing special about snapshot creation that makes it
advantageous to do from the kernel, so I'd like to remove the
create_snap sysfs interface. That is,
/sys/bus/rbd/devices/<id>/create_snap
would be removed.
Does anyone rely on the sysfs interface for creating rbd
snapshots? If so, how hard would it be to replace with:
rbd snap create pool/image@snap
Is there any benefit to the sysfs interface that I'm missing?
Josh
This patch implements this proposal, removing the code that
implements the "snap_create" sysfs interface for rbd images.
As a result, quite a lot of other supporting code goes away.
Suggested-by: Josh Durgin <josh.durgin@inktank.com>
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
|
||
|---|---|---|
| .. | ||
| configfs-spear-pcie-gadget | ||
| debugfs-ec | ||
| debugfs-ideapad | ||
| debugfs-olpc | ||
| debugfs-pfo-nx-crypto | ||
| debugfs-pktcdvd | ||
| dev-kmsg | ||
| evm | ||
| ima_policy | ||
| procfs-diskstats | ||
| pstore | ||
| sysfs-ata | ||
| sysfs-block | ||
| sysfs-block-dm | ||
| sysfs-block-rssd | ||
| sysfs-block-zram | ||
| sysfs-bus-bcma | ||
| sysfs-bus-css | ||
| sysfs-bus-event_source-devices-format | ||
| sysfs-bus-fcoe | ||
| sysfs-bus-hsi | ||
| sysfs-bus-i2c-devices-fsa9480 | ||
| sysfs-bus-i2c-devices-hm6352 | ||
| sysfs-bus-i2c-devices-lm3533 | ||
| sysfs-bus-iio | ||
| sysfs-bus-iio-frequency-ad9523 | ||
| sysfs-bus-iio-frequency-adf4350 | ||
| sysfs-bus-iio-light-lm3533-als | ||
| sysfs-bus-media | ||
| sysfs-bus-pci | ||
| sysfs-bus-pci-devices-cciss | ||
| sysfs-bus-pci-drivers-ehci_hcd | ||
| sysfs-bus-rbd | ||
| sysfs-bus-rpmsg | ||
| sysfs-bus-umc | ||
| sysfs-bus-usb | ||
| sysfs-bus-usb-devices-usbsevseg | ||
| sysfs-c2port | ||
| sysfs-cfq-target-latency | ||
| sysfs-class | ||
| sysfs-class-backlight-driver-adp8870 | ||
| sysfs-class-backlight-driver-lm3533 | ||
| sysfs-class-bdi | ||
| sysfs-class-devfreq | ||
| sysfs-class-extcon | ||
| sysfs-class-lcd | ||
| sysfs-class-led | ||
| sysfs-class-led-driver-lm3533 | ||
| sysfs-class-mtd | ||
| sysfs-class-net-batman-adv | ||
| sysfs-class-net-mesh | ||
| sysfs-class-pktcdvd | ||
| sysfs-class-power | ||
| sysfs-class-regulator | ||
| sysfs-class-rtc-rtc0-device-rtc_calibration | ||
| sysfs-class-scsi_host | ||
| sysfs-class-uwb_rc | ||
| sysfs-class-uwb_rc-wusbhc | ||
| sysfs-dev | ||
| sysfs-devices | ||
| sysfs-devices-edac | ||
| sysfs-devices-memory | ||
| sysfs-devices-mmc | ||
| sysfs-devices-node | ||
| sysfs-devices-platform-_UDC_-gadget | ||
| sysfs-devices-platform-docg3 | ||
| sysfs-devices-platform-sh_mobile_lcdc_fb | ||
| sysfs-devices-power | ||
| sysfs-devices-soc | ||
| sysfs-devices-system-cpu | ||
| sysfs-devices-system-ibm-rtl | ||
| sysfs-devices-system-xen_cpu | ||
| sysfs-driver-hid | ||
| sysfs-driver-hid-lenovo-tpkbd | ||
| sysfs-driver-hid-logitech-lg4ff | ||
| sysfs-driver-hid-multitouch | ||
| sysfs-driver-hid-picolcd | ||
| sysfs-driver-hid-prodikeys | ||
| sysfs-driver-hid-roccat-arvo | ||
| sysfs-driver-hid-roccat-isku | ||
| sysfs-driver-hid-roccat-kone | ||
| sysfs-driver-hid-roccat-koneplus | ||
| sysfs-driver-hid-roccat-kovaplus | ||
| sysfs-driver-hid-roccat-pyra | ||
| sysfs-driver-hid-roccat-savu | ||
| sysfs-driver-hid-wiimote | ||
| sysfs-driver-samsung-laptop | ||
| sysfs-driver-wacom | ||
| sysfs-firmware-acpi | ||
| sysfs-firmware-dmi | ||
| sysfs-firmware-gsmi | ||
| sysfs-firmware-log | ||
| sysfs-firmware-memmap | ||
| sysfs-firmware-sfi | ||
| sysfs-firmware-sgi_uv | ||
| sysfs-fs-ext4 | ||
| sysfs-gpio | ||
| sysfs-i2c-bmp085 | ||
| sysfs-ibft | ||
| sysfs-kernel-fscaps | ||
| sysfs-kernel-iommu_groups | ||
| sysfs-kernel-mm | ||
| sysfs-kernel-mm-hugepages | ||
| sysfs-kernel-slab | ||
| sysfs-kernel-uids | ||
| sysfs-memory-page-offline | ||
| sysfs-module | ||
| sysfs-ocfs2 | ||
| sysfs-platform-asus-laptop | ||
| sysfs-platform-asus-wmi | ||
| sysfs-platform-at91 | ||
| sysfs-platform-eeepc-laptop | ||
| sysfs-platform-ideapad-laptop | ||
| sysfs-platform-kim | ||
| sysfs-power | ||
| sysfs-pps | ||
| sysfs-profiling | ||
| sysfs-ptp | ||
| sysfs-tty | ||
| sysfs-wusb_cbaf | ||