Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/android/binder
History
Alice Ryhl 361e0ff456 rust_binder: remove spin_lock() in rust_shrink_free_page() 
When forward-porting Rust Binder to 6.18, I neglected to take commit
fb56fdf8b9 ("mm/list_lru: split the lock to per-cgroup scope") into
account, and apparently I did not end up running the shrinker callback
when I sanity tested the driver before submission. This leads to crashes
like the following:

	============================================
	WARNING: possible recursive locking detected
	6.18.0-mainline-maybe-dirty #1 Tainted: G          IO
	--------------------------------------------
	kswapd0/68 is trying to acquire lock:
	ffff956000fa18b0 (&l->lock){+.+.}-{2:2}, at: lock_list_lru_of_memcg+0x128/0x230

	but task is already holding lock:
	ffff956000fa18b0 (&l->lock){+.+.}-{2:2}, at: rust_helper_spin_lock+0xd/0x20

	other info that might help us debug this:
	 Possible unsafe locking scenario:

	       CPU0
	       ----
	  lock(&l->lock);
	  lock(&l->lock);

	 *** DEADLOCK ***

	 May be due to missing lock nesting notation

	3 locks held by kswapd0/68:
	 #0: ffffffff90d2e260 (fs_reclaim){+.+.}-{0:0}, at: kswapd+0x597/0x1160
	 #1: ffff956000fa18b0 (&l->lock){+.+.}-{2:2}, at: rust_helper_spin_lock+0xd/0x20
	 #2: ffffffff90cf3680 (rcu_read_lock){....}-{1:2}, at: lock_list_lru_of_memcg+0x2d/0x230

To fix this, remove the spin_lock() call from rust_shrink_free_page().

Cc: stable <stable@kernel.org>
Fixes: eafedbc7c0 ("rust_binder: add Rust Binder driver")
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Link: https://patch.msgid.link/20251202-binder-shrink-unspin-v1-1-263efb9ad625@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2025-12-29 11:34:16 +01:00
..
node
…
range_alloc rust: rbtree: add immutable cursor 2025-11-16 21:56:57 +01:00
Makefile
…
allocation.rs
…
context.rs
…
deferred_close.rs
…
defs.rs
…
error.rs rust_binder: use `kernel::fmt` 2025-10-20 04:04:23 +02:00
freeze.rs Rust changes for v6.19 2025-12-03 14:16:49 -08:00
node.rs rust_binder: fix race condition on death_list 2025-11-26 13:26:59 +01:00
page_range.rs rust_binder: remove spin_lock() in rust_shrink_free_page() 2025-12-29 11:34:16 +01:00
page_range_helper.c
…
page_range_helper.h
…
process.rs Char/Misc/IIO driver updates for 6.19-rc1 2025-12-06 18:34:24 -08:00
rust_binder.h
…
rust_binder_events.c
…
rust_binder_events.h
…
rust_binder_internal.h
…
rust_binder_main.rs rust_binder: use compat_ptr_ioctl 2025-11-26 13:24:25 +01:00
rust_binderfs.c convert rust_binderfs 2025-11-17 23:59:27 -05:00
stats.rs rust: replace `CStr` with `core::ffi::CStr` 2025-10-22 07:47:27 +02:00
thread.rs rust_binder: move BC_FREE_BUFFER drop inside if statement 2025-11-26 13:24:28 +01:00
trace.rs
…
transaction.rs rust_binder: report freeze notification only when fully frozen 2025-10-13 11:06:20 +02:00