Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/net/ethernet/microchip
History
Guenter Roeck f164b29663 net: microchip: vcap: Add typegroup table terminators in kunit tests 
VCAP API unit tests fail randomly with errors such as

   # vcap_api_iterator_init_test: EXPECTATION FAILED at drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c:387
   Expected 134 + 7 == iter.offset, but
       134 + 7 == 141 (0x8d)
       iter.offset == 17214 (0x433e)
   # vcap_api_iterator_init_test: EXPECTATION FAILED at drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c:388
   Expected 5 == iter.reg_idx, but
       iter.reg_idx == 702 (0x2be)
   # vcap_api_iterator_init_test: EXPECTATION FAILED at drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c:389
   Expected 11 == iter.reg_bitpos, but
       iter.reg_bitpos == 15 (0xf)
   # vcap_api_iterator_init_test: pass:0 fail:1 skip:0 total:1

Comments in the code state that "A typegroup table ends with an all-zero
terminator". Add the missing terminators.

Some of the typegroups did have a terminator of ".offset = 0, .width = 0,
.value = 0,". Replace those terminators with "{ }" (no trailing ',') for
consistency and to excplicitly state "this is a terminator".

Fixes: 67d637516f ("net: microchip: sparx5: Adding KUNIT test for the VCAP API")
Cc: Steen Hegelund <steen.hegelund@microchip.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20241119213202.2884639-1-linux@roeck-us.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
 		2024-11-24 16:52:13 -08:00
..
fdma net: microchip: Make FDMA config symbol invisible 2024-10-01 11:31:43 +02:00
lan865x microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY 2024-09-11 20:53:46 -07:00
lan966x net: ethernet: Switch back to struct platform_driver::remove() 2024-10-04 16:39:56 -07:00
lan969x net: sparx5: add missing lan969x Kconfig dependency 2024-11-14 19:25:51 -08:00
sparx5 net: sparx5: execute sparx5_vcap_init() on lan969x 2024-11-05 13:31:08 +01:00
vcap net: microchip: vcap: Add typegroup table terminators in kunit tests 2024-11-24 16:52:13 -08:00
Kconfig net: lan969x: add match data for lan969x 2024-10-30 18:08:05 -07:00
Makefile net: lan969x: add match data for lan969x 2024-10-30 18:08:05 -07:00
enc28j60.c net: enc28j60: Use threaded interrupt instead of workqueue 2023-05-11 18:00:37 -07:00
enc28j60_hw.h
…
encx24j600-regmap.c net: encx24j600: constify struct regmap_bus/regmap_config 2024-07-05 17:02:20 -07:00
encx24j600.c net: encx24j600: Correct spelling in comments 2024-04-25 19:13:26 -07:00
encx24j600_hw.h net: encx24j600: Correct spelling in comments 2024-04-25 19:13:26 -07:00
lan743x_ethtool.c net: lan743x: Add support to ethtool phylink get and set settings 2024-09-11 11:06:12 +01:00
lan743x_ethtool.h
…
lan743x_main.c net: lan743x: Add support to ethtool phylink get and set settings 2024-09-11 11:06:12 +01:00
lan743x_main.h net: lan743x: Add support to ethtool phylink get and set settings 2024-09-11 11:06:12 +01:00
lan743x_ptp.c net: lan743x: Remove duplicate check 2024-10-14 17:22:43 -07:00
lan743x_ptp.h net: microchip: lan743x: Reduce PTP timeout on HW failure 2024-05-06 11:41:32 +02:00