mirror of https://github.com/torvalds/linux.git
c8c101ae39
mptcp_join 'implicit EP' test currently fails when using ip mptcp:
$ ./mptcp_join.sh -iI
<snip>
001 implicit EP creation[fail] expected '10.0.2.2 10.0.2.2 id 1 implicit' found '10.0.2.2 id 1 rawflags 10 '
Error: too many addresses or duplicate one: -22.
ID change is prevented[fail] expected '10.0.2.2 10.0.2.2 id 1 implicit' found '10.0.2.2 id 1 rawflags 10 '
modif is allowed[fail] expected '10.0.2.2 10.0.2.2 id 1 signal' found '10.0.2.2 id 1 signal '
This happens because of two reasons:
- iproute v6.3.0 does not support the implicit flag, fixed with
iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit
flag")
- pm_nl_check_endpoint wrongly expects the ip address to be repeated two
times in iproute output, and does not account for a final whitespace
in it.
This fixes the issue trimming the whitespace in the output string and
removing the double address in the expected string.
Fixes:
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile | ||
| config | ||
| diag.sh | ||
| mptcp_connect.c | ||
| mptcp_connect.sh | ||
| mptcp_inq.c | ||
| mptcp_join.sh | ||
| mptcp_lib.sh | ||
| mptcp_sockopt.c | ||
| mptcp_sockopt.sh | ||
| pm_netlink.sh | ||
| pm_nl_ctl.c | ||
| settings | ||
| simult_flows.sh | ||
| userspace_pm.sh | ||