linux/drivers/net/ppp
Arnaud Lecomte aabc6596ff net: ppp: Add bound checking for skb data on ppp_sync_txmung
Ensure we have enough data in linear buffer from skb before accessing
initial bytes. This prevents potential out-of-bounds accesses
when processing short packets.

When ppp_sync_txmung receives an incoming package with an empty
payload:
(remote) gef➤  p *(struct pppoe_hdr *) (skb->head + skb->network_header)
$18 = {
	type = 0x1,
	ver = 0x1,
	code = 0x0,
	sid = 0x2,
        length = 0x0,
	tag = 0xffff8880371cdb96
}

from the skb struct (trimmed)
      tail = 0x16,
      end = 0x140,
      head = 0xffff88803346f400 "4",
      data = 0xffff88803346f416 ":\377",
      truesize = 0x380,
      len = 0x0,
      data_len = 0x0,
      mac_len = 0xe,
      hdr_len = 0x0,

it is not safe to access data[2].

Reported-by: syzbot+29fc8991b0ecb186cf40@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=29fc8991b0ecb186cf40
Tested-by: syzbot+29fc8991b0ecb186cf40@syzkaller.appspotmail.com
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Arnaud Lecomte <contact@arnaud-lcm.com>
Link: https://patch.msgid.link/20250408-bound-checking-ppp_txmung-v2-1-94bb6e1b92d0@arnaud-lcm.com
[pabeni@redhat.com: fixed subj typo]
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2025-04-10 11:24:17 +02:00
..
Kconfig net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition 2023-06-06 13:28:30 +02:00
Makefile
bsd_comp.c net: fill in MODULE_DESCRIPTION()s for ppp 2024-02-15 08:03:46 -08:00
ppp_async.c ppp: fix ppp_async_encode() illegal access 2024-10-10 08:47:13 -07:00
ppp_deflate.c move asm/unaligned.h to linux/unaligned.h 2024-10-02 17:23:23 -04:00
ppp_generic.c net: move misc netdev_lock flavors to a separate header 2025-03-08 09:06:50 -08:00
ppp_mppe.c move asm/unaligned.h to linux/unaligned.h 2024-10-02 17:23:23 -04:00
ppp_mppe.h
ppp_synctty.c net: ppp: Add bound checking for skb data on ppp_sync_txmung 2025-04-10 11:24:17 +02:00
pppoe.c ppp: use IFF_NO_QUEUE in virtual interfaces 2025-03-04 17:11:17 -08:00
pppox.c
pptp.c ppp: use IFF_NO_QUEUE in virtual interfaces 2025-03-04 17:11:17 -08:00