linux/drivers/net/ethernet/renesas
Jacob Keller 51d58c0c79 renesas: reject PTP_STRICT_FLAGS as unsupported
The ravb_ptp_extts() function checks the flags coming from the
PTP_EXTTS_REQUEST ioctl, to ensure that future flags are not accepted on
accident.

This was updated to 'honor' the PTP_STRICT_FLAGS in commit 6138e687c7
("ptp: Introduce strict checking of external time stamp options.").
However, the driver does not *actually* validate the flags.

I originally fixed this driver to reject future flags in commit
592025a03b ("renesas: reject unsupported external timestamp flags"). It
is still unclear whether this hardware timestamps the rising, falling, or
both edges of the input signal.

Accepting requests with PTP_STRICT_FLAGS is a bug, as this could lead to
users mistakenly assuming a request with PTP_RISING_EDGE actually
timestamps the rising edge only.

Reject requests with PTP_STRICT_FLAGS (and hence all PTP_EXTTS_REQUEST2
requests) until someone with access to the datasheet or hardware knowledge
can confirm the timestamping behavior and update this driver.

Fixes: 6138e687c7 ("ptp: Introduce strict checking of external time stamp options.")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250312-jk-net-fixes-supported-extts-flags-v2-2-ea930ba82459@intel.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2025-03-20 08:50:02 +01:00
..
Kconfig net: ethernet: rtsn: Add support for Renesas Ethernet-TSN 2024-06-21 12:24:54 +01:00
Makefile net: ethernet: rtsn: Add support for Renesas Ethernet-TSN 2024-06-21 12:24:54 +01:00
ravb.h net: ravb: Add VLAN checksum support 2024-10-17 21:24:25 -05:00
ravb_main.c net: ravb: Fix missing rtnl lock in suspend/resume path 2025-01-30 11:23:01 +01:00
ravb_ptp.c renesas: reject PTP_STRICT_FLAGS as unsupported 2025-03-20 08:50:02 +01:00
rcar_gen4_ptp.c net: ethernet: renesas: rcar_gen4_ptp: Remove bool conversion 2025-02-24 17:50:16 -08:00
rcar_gen4_ptp.h net: ethernet: renesas: rcar_gen4_ptp: Get clock increment from clock rate 2023-11-23 12:02:49 +01:00
rswitch.c net: renesas: rswitch: Convert to for_each_available_child_of_node() 2025-02-07 11:58:32 -08:00
rswitch.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2024-12-19 11:35:07 -08:00
rtsn.c net: ethernet: rtsn: fix potential memory leak in rtsn_start_xmit() 2024-10-15 10:59:29 -07:00
rtsn.h net: ethernet: rtsn: Add support for Renesas Ethernet-TSN 2024-06-21 12:24:54 +01:00
sh_eth.c net: sh_eth: Fix missing rtnl lock in suspend/resume path 2025-01-30 11:23:01 +01:00
sh_eth.h Revert "sh_eth: remove open coded netif_running()" 2023-03-28 19:23:32 -07:00