mirror of https://github.com/torvalds/linux.git
285b2c74cf
Call cs_dsp_mock_xm_header_get_fw_version() to get the firmware version
from the dummy XM header data in cs_dsp_bin_err_test_common_init().
Make the same change to cs_dsp_bin_test_common_init() and remove the
cs_dsp_mock_xm_header_get_fw_version_from_regmap() function.
The code in cs_dsp_test_bin.c was correctly calling
cs_dsp_mock_xm_header_get_fw_version_from_regmap() to fetch the fw version
from a dummy header it wrote to XM registers. However in
cs_dsp_test_bin_error.c the test doesn't stuff a dummy header into XM, it
populates it the normal way using a wmfw file. It should have called
cs_dsp_mock_xm_header_get_fw_version() to get the data from its blob
buffer, but was calling cs_dsp_mock_xm_header_get_fw_version_from_regmap().
As nothing had been written to the registers this returned the value of
uninitialized data.
The only other use of cs_dsp_mock_xm_header_get_fw_version_from_regmap()
was cs_dsp_test_bin.c, but it doesn't need to use it. It already has a
blob buffer containing the dummy XM header so it can use
cs_dsp_mock_xm_header_get_fw_version() to read from that.
Fixes:
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| cs_dsp_mock_bin.c | ||
| cs_dsp_mock_mem_maps.c | ||
| cs_dsp_mock_regmap.c | ||
| cs_dsp_mock_utils.c | ||
| cs_dsp_mock_wmfw.c | ||
| cs_dsp_test_bin.c | ||
| cs_dsp_test_bin_error.c | ||
| cs_dsp_test_callbacks.c | ||
| cs_dsp_test_control_cache.c | ||
| cs_dsp_test_control_parse.c | ||
| cs_dsp_test_control_rw.c | ||
| cs_dsp_test_wmfw.c | ||
| cs_dsp_test_wmfw_error.c | ||
| cs_dsp_tests.c | ||