mirror of https://github.com/torvalds/linux.git
c0b1da281d
Switch to u64 arithmetic and use DIV_ROUND_CLOSEST_ULL() to avoid the overflow. buffer[i] is unsigned int and is limited by the lirc core to IR_MAX_DURATION, which is 500000. idata->freq is u32, which has a max value of 0xFFFFFFFF. In the case where buffer[i] is 500000, idata->freq overflows the u32 multiplication for any values >= 8590. 0xFFFFFFFF / 500000 ~= 8589 By casting buffer[i] to u64, idata->freq can be any u32 value without overflowing the multiplication. 0xFFFFFFFFFFFFFFFF / 500000 ~= 36893488147419 (> 4294967295) The result of the final operation will fit back into the unsigned int limits without any issues. 500000 * 0xFFFFFFFF / 1000000 = 0x80000000 (< 0xFFFFFFFF) Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> |
||
|---|---|---|
| .. | ||
| img-ir | ||
| keymaps | ||
| Kconfig | ||
| Makefile | ||
| ati_remote.c | ||
| bpf-lirc.c | ||
| ene_ir.c | ||
| ene_ir.h | ||
| fintek-cir.c | ||
| fintek-cir.h | ||
| gpio-ir-recv.c | ||
| gpio-ir-tx.c | ||
| igorplugusb.c | ||
| iguanair.c | ||
| imon.c | ||
| imon_raw.c | ||
| ir-hix5hd2.c | ||
| ir-imon-decoder.c | ||
| ir-jvc-decoder.c | ||
| ir-mce_kbd-decoder.c | ||
| ir-nec-decoder.c | ||
| ir-rc5-decoder.c | ||
| ir-rc6-decoder.c | ||
| ir-rcmm-decoder.c | ||
| ir-sanyo-decoder.c | ||
| ir-sharp-decoder.c | ||
| ir-sony-decoder.c | ||
| ir-spi.c | ||
| ir-xmp-decoder.c | ||
| ir_toy.c | ||
| ite-cir.c | ||
| ite-cir.h | ||
| lirc_dev.c | ||
| mceusb.c | ||
| meson-ir-tx.c | ||
| meson-ir.c | ||
| mtk-cir.c | ||
| nuvoton-cir.c | ||
| nuvoton-cir.h | ||
| pwm-ir-tx.c | ||
| rc-core-priv.h | ||
| rc-ir-raw.c | ||
| rc-loopback.c | ||
| rc-main.c | ||
| redrat3.c | ||
| serial_ir.c | ||
| st_rc.c | ||
| streamzap.c | ||
| sunxi-cir.c | ||
| ttusbir.c | ||
| winbond-cir.c | ||
| xbox_remote.c | ||