Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/clk/meson
History
Marek Szyprowski 7e2e4e32cd
clk: amlogic: fix recent code refactoring 
Commit 4c4e17f270 ("clk: amlogic: naming consistency alignment")
refactored some internals in the g12a meson clock driver. Unfortunately
it introduced a bug in the clock init data, which results in the
following kernel panic:

Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
Mem abort info:
...
Data abort info:
...
[0000000000000000] user address but active_mm is swapper
Internal error: Oops: 0000000096000004 [#1]  SMP
Modules linked in:
CPU: 4 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.17.0-rc1+ #11158 PREEMPT
Hardware name: Hardkernel ODROID-N2 (DT)
pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : __clk_register+0x60/0x92c
lr : __clk_register+0x48/0x92c
...
Call trace:
 __clk_register+0x60/0x92c (P)
 devm_clk_hw_register+0x5c/0xd8
 meson_eeclkc_probe+0x74/0x110
 g12a_clkc_probe+0x2c/0x58
 platform_probe+0x5c/0xac
 really_probe+0xbc/0x298
 __driver_probe_device+0x78/0x12c
 driver_probe_device+0xdc/0x164
 __driver_attach+0x9c/0x1ac
 bus_for_each_dev+0x74/0xd0
 driver_attach+0x24/0x30
 bus_add_driver+0xe4/0x208
 driver_register+0x60/0x128
 __platform_driver_register+0x24/0x30
 g12a_clkc_driver_init+0x1c/0x28
 do_one_initcall+0x64/0x308
 kernel_init_freeable+0x27c/0x4f8
 kernel_init+0x20/0x1d8
 ret_from_fork+0x10/0x20
Code: 52800038 aa0003fc b9010018 52819801 (f9400260)
---[ end trace 0000000000000000 ]---

Fix this by correcting the clock init data.

Fixes: 4c4e17f270 ("clk: amlogic: naming consistency alignment")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on BananPi M2S
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
 		2025-09-19 21:58:50 -07:00
..
Kconfig clk: amlogic: drop meson-clkcee 2025-09-04 18:27:12 +02:00
Makefile clk: amlogic: drop meson-clkcee 2025-09-04 18:27:12 +02:00
a1-peripherals.c clk: amlogic: introduce a common pclk definition 2025-09-04 18:27:12 +02:00
a1-pll.c clk: amlogic: use probe helper in mmio based controllers 2025-09-04 18:27:12 +02:00
axg-aoclk.c clk: amlogic: use the common pclk definition 2025-09-04 18:27:12 +02:00
axg-audio.c clk: amlogic: drop clk_regmap tables 2025-07-02 15:38:19 +02:00
axg.c clk: amlogic: introduce a common pclk definition 2025-09-04 18:27:12 +02:00
c3-peripherals.c clk: amlogic: c3-peripherals: use helper for basic composite clocks 2025-09-04 18:27:12 +02:00
c3-pll.c clk: amlogic: use probe helper in mmio based controllers 2025-09-04 18:27:12 +02:00
clk-cpu-dyndiv.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
clk-cpu-dyndiv.h
…
clk-dualdiv.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
clk-dualdiv.h
…
clk-mpll.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
clk-mpll.h clk: meson: mpll: Delete a useless spinlock from the MPLL 2024-09-30 11:27:54 +02:00
clk-phase.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
clk-phase.h
…
clk-pll.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
clk-pll.h clk: meson: Support PLL with fixed fractional denominators 2024-09-30 11:27:36 +02:00
clk-regmap.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
clk-regmap.h clk: amlogic: move PCLK definition to clkc-utils 2025-09-04 18:27:12 +02:00
g12a-aoclk.c clk: amlogic: use the common pclk definition 2025-09-04 18:27:12 +02:00
g12a.c clk: amlogic: fix recent code refactoring 2025-09-19 21:58:50 -07:00
gxbb-aoclk.c clk: amlogic: use the common pclk definition 2025-09-04 18:27:12 +02:00
gxbb.c clk: amlogic: introduce a common pclk definition 2025-09-04 18:27:12 +02:00
meson-aoclk.c clk: amlogic: aoclk: use clkc-utils syscon probe 2025-09-04 18:27:12 +02:00
meson-aoclk.h clk: amlogic: aoclk: use clkc-utils syscon probe 2025-09-04 18:27:12 +02:00
meson-clkc-utils.c clk: amlogic: add probe helper for mmio based controllers 2025-09-04 18:27:12 +02:00
meson-clkc-utils.h clk: amlogic: add composite clock helpers 2025-09-04 18:27:12 +02:00
meson8-ddr.c clk: amlogic: use probe helper in mmio based controllers 2025-09-04 18:27:12 +02:00
meson8b.c clk: amlogic: introduce a common pclk definition 2025-09-04 18:27:12 +02:00
parm.h
…
s4-peripherals.c clk: amlogic: align s4 and c3 pwm clock descriptions 2025-09-04 18:27:12 +02:00
s4-pll.c clk: amlogic: use probe helper in mmio based controllers 2025-09-04 18:27:12 +02:00
sclk-div.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
sclk-div.h
…
vclk.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
vclk.h clk: meson: add vclk driver 2024-04-10 09:46:21 +02:00
vid-pll-div.c clk: amlogic: get regmap with clk_regmap_init 2025-07-02 15:38:19 +02:00
vid-pll-div.h
…