Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/usb/phy
History
Fabio Estevam 4993508653 usb: phy: mxs: Fix NULL pointer dereference on i.MX23/28 
Commit e93650994a ("usb: phy: mxs: add usb charger type detection")
causes the following kernel hang on i.MX28:

[    2.207973] usbcore: registered new interface driver usb-storage
[    2.235659] Unable to handle kernel NULL pointer dereference at virtual address 00000188
[    2.244195] pgd = (ptrval)
[    2.246994] [00000188] *pgd=00000000
[    2.250676] Internal error: Oops: 5 [#1] ARM
[    2.254979] Modules linked in:
[    2.258089] CPU: 0 PID: 1 Comm: swapper Not tainted 4.15.0-rc8-next-20180117-00002-g75d5f21 #7
[    2.266724] Hardware name: Freescale MXS (Device Tree)
[    2.271921] PC is at regmap_read+0x0/0x5c
[    2.275977] LR is at mxs_phy_charger_detect+0x34/0x1dc

mxs_phy_charger_detect() makes accesses to the anatop registers via regmap,
however i.MX23/28 do not have such registers, which causes a NULL pointer
dereference.

Fix the issue by doing a NULL check on the 'regmap' pointer.

Fixes: e93650994a ("usb: phy: mxs: add usb charger type detection")
Cc: <stable@vger.kernel.org> # v4.15
Reviewed-by: Li Jun <jun.li@nxp.com>
Acked-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
 		2018-02-12 10:51:37 +02:00
..
Kconfig
…
Makefile USB/PHY patches for 4.15-rc1 2017-11-13 21:14:07 -08:00
of.c
…
phy-ab8500-usb.c
…
phy-am335x-control.c
…
phy-am335x-control.h
…
phy-am335x.c
…
phy-fsl-usb.c
…
phy-fsl-usb.h
…
phy-generic.c
…
phy-generic.h
…
phy-gpio-vbus-usb.c
…
phy-isp1301-omap.c
…
phy-isp1301.c
…
phy-keystone.c
…
phy-mv-usb.c USB: move many drivers to use DEVICE_ATTR_WO 2018-01-24 08:49:52 +01:00
phy-mv-usb.h
…
phy-mxs-usb.c usb: phy: mxs: Fix NULL pointer dereference on i.MX23/28 2018-02-12 10:51:37 +02:00
phy-omap-otg.c
…
phy-tahvo.c USB: move many drivers to use DEVICE_ATTR_RO 2018-01-24 08:49:52 +01:00
phy-tegra-usb.c
…
phy-twl6030-usb.c USB: move many drivers to use DEVICE_ATTR_RO 2018-01-24 08:49:52 +01:00
phy-ulpi-viewport.c
…
phy-ulpi.c
…
phy.c usb: phy: Factor out the usb charger initialization 2017-12-12 13:04:03 +02:00