mirror of https://github.com/torvalds/linux.git
b6d8878d24
The kbuild test robot reports that when building with W=1, GCC will warn for a couple of missing prototypes in syscall.c: | arch/arm64/kernel/syscall.c:157:6: warning: no previous prototype for 'do_el0_svc' [-Wmissing-prototypes] | 157 | void do_el0_svc(struct pt_regs *regs) | | ^~~~~~~~~~ | arch/arm64/kernel/syscall.c:164:6: warning: no previous prototype for 'do_el0_svc_compat' [-Wmissing-prototypes] | 164 | void do_el0_svc_compat(struct pt_regs *regs) | | ^~~~~~~~~~~~~~~~~ While this isn't a functional problem, as a general policy we should include the prototype for functions wherever possible to catch any accidental divergence between the prototype and implementation. Here we can easily include <asm/exception.h>, so let's do so. While there are a number of warnings elsewhere and some warnings enabled under W=1 are of questionable benefit, this change helps to make the code more robust as it evolved and reduces the noise somewhat, so it seems worthwhile. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Reported-by: kernel test robot <lkp@intel.com> Cc: Will Deacon <will@kernel.org> Link: https://lore.kernel.org/r/202101141046.n8iPO3mw-lkp@intel.com Link: https://lore.kernel.org/r/20210114124812.17754-1-mark.rutland@arm.com Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> |
||
|---|---|---|
| .. | ||
| probes | ||
| vdso | ||
| vdso32 | ||
| .gitignore | ||
| Makefile | ||
| acpi.c | ||
| acpi_numa.c | ||
| acpi_parking_protocol.c | ||
| alternative.c | ||
| armv8_deprecated.c | ||
| asm-offsets.c | ||
| cacheinfo.c | ||
| cpu-reset.S | ||
| cpu-reset.h | ||
| cpu_errata.c | ||
| cpu_ops.c | ||
| cpufeature.c | ||
| cpuidle.c | ||
| cpuinfo.c | ||
| crash_core.c | ||
| crash_dump.c | ||
| debug-monitors.c | ||
| efi-entry.S | ||
| efi-header.S | ||
| efi-rt-wrapper.S | ||
| efi.c | ||
| entry-common.c | ||
| entry-fpsimd.S | ||
| entry-ftrace.S | ||
| entry.S | ||
| fpsimd.c | ||
| ftrace.c | ||
| head.S | ||
| hibernate-asm.S | ||
| hibernate.c | ||
| hw_breakpoint.c | ||
| hyp-stub.S | ||
| image-vars.h | ||
| image.h | ||
| insn.c | ||
| io.c | ||
| irq.c | ||
| jump_label.c | ||
| kaslr.c | ||
| kexec_image.c | ||
| kgdb.c | ||
| kuser32.S | ||
| machine_kexec.c | ||
| machine_kexec_file.c | ||
| module-plts.c | ||
| module.c | ||
| mte.c | ||
| paravirt.c | ||
| pci.c | ||
| perf_callchain.c | ||
| perf_event.c | ||
| perf_regs.c | ||
| pointer_auth.c | ||
| process.c | ||
| proton-pack.c | ||
| psci.c | ||
| ptrace.c | ||
| reloc_test_core.c | ||
| reloc_test_syms.S | ||
| relocate_kernel.S | ||
| return_address.c | ||
| sdei.c | ||
| setup.c | ||
| signal.c | ||
| signal32.c | ||
| sigreturn32.S | ||
| sleep.S | ||
| smccc-call.S | ||
| smp.c | ||
| smp_spin_table.c | ||
| stacktrace.c | ||
| suspend.c | ||
| sys.c | ||
| sys32.c | ||
| sys_compat.c | ||
| syscall.c | ||
| time.c | ||
| topology.c | ||
| trace-events-emulation.h | ||
| traps.c | ||
| vdso.c | ||
| vmlinux.lds.S | ||