linux/tools/net/ynl/pyynl
Asbjørn Sloth Tønnesen b4ada0618e tools: ynl-gen: fix nested array counting
The blamed commit introduced the concept of split attribute
counting, and later allocating an array to hold them, however
TypeArrayNest wasn't updated to use the new counting variable.

Abbreviated example from tools/net/ynl/generated/nl80211-user.c:
nl80211_if_combination_attributes_parse(...):
  unsigned int n_limits = 0;
  [...]
  ynl_attr_for_each(attr, nlh, yarg->ys->family->hdr_len)
	if (type == NL80211_IFACE_COMB_LIMITS)
		ynl_attr_for_each_nested(attr2, attr)
			dst->_count.limits++;
  if (n_limits) {
	dst->_count.limits = n_limits;
	/* allocate and parse attributes */
  }

In the above example n_limits is guaranteed to always be 0,
hence the conditional is unsatisfiable and is optimized out.

This patch changes the attribute counting to use n_limits++ in the
attribute counting loop in the above example.

Fixes: 58da455b31 ("tools: ynl-gen: improve unwind on parsing errors")
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://patch.msgid.link/20250902160001.760953-1-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-09-03 15:18:34 -07:00
..
lib tools: ynl: support packing binary arrays of scalars 2025-07-17 16:13:58 -07:00
.gitignore tools: ynl: move python code to separate sub-directory 2025-01-09 12:53:27 -08:00
__init__.py tools: ynl: move python code to separate sub-directory 2025-01-09 12:53:27 -08:00
cli.py tools: ynl: default to --process-unknown in installed mode 2025-07-13 23:00:37 +01:00
ethtool.py tools/net/ynl: ethtool: fix crash when Hardware Clock info is missing 2025-05-09 15:03:07 -07:00
ynl_gen_c.py tools: ynl-gen: fix nested array counting 2025-09-03 15:18:34 -07:00
ynl_gen_rst.py tools: ynl: fix typo in info string 2025-04-29 15:13:52 -07:00