linux/sound/soc/tegra
Mohan Kumar 6781b962d9
ASoC: tegra: Fix CBB error during probe()
When Tegra audio drivers are built as part of the kernel image,
TIMEOUT_ERR is observed from cbb-fabric. Following is seen on
Jetson AGX Orin during boot:

[    8.012482] **************************************
[    8.017423] CPU:0, Error:cbb-fabric, Errmon:2
[    8.021922]    Error Code            : TIMEOUT_ERR
[    8.025966]    Overflow              : Multiple TIMEOUT_ERR
[    8.030644]
[    8.032175]    Error Code            : TIMEOUT_ERR
[    8.036217]    MASTER_ID             : CCPLEX
[    8.039722]    Address               : 0x290a0a8
[    8.043318]    Cache                 : 0x1 -- Bufferable
[    8.047630]    Protection            : 0x2 -- Unprivileged, Non-Secure, Data Access
[    8.054628]    Access_Type           : Write

[    8.106130] WARNING: CPU: 0 PID: 124 at drivers/soc/tegra/cbb/tegra234-cbb.c:604 tegra234_cbb_isr+0x134/0x178

[    8.240602] Call trace:
[    8.243126]  tegra234_cbb_isr+0x134/0x178
[    8.247261]  __handle_irq_event_percpu+0x60/0x238
[    8.252132]  handle_irq_event+0x54/0xb8

These errors happen when MVC device, which is a child of AHUB
device, tries to access its device registers. This happens as
part of call tegra210_mvc_reset_vol_settings() in MVC device
probe().

The root cause of this problem is, the child MVC device gets
probed before the AHUB clock gets enabled. The AHUB clock is
enabled in runtime PM resume of parent AHUB device and due to
the wrong sequence of pm_runtime_enable() in AHUB driver,
runtime PM resume doesn't happen for AHUB device when MVC makes
register access.

Fix this by calling pm_runtime_enable() for parent AHUB device
before of_platform_populate() in AHUB driver. This ensures that
clock becomes available when MVC makes register access.

Fixes: 16e1bcc2ca ("ASoC: tegra: Add Tegra210 based AHUB driver")
Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
Signed-off-by: Ritu Chaudhary <rituc@nvidia.com>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Link: https://patch.msgid.link/20240823144342.4123814-3-spujar@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2024-08-23 23:07:55 +01:00
..
Kconfig ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS 2024-07-22 13:04:50 +01:00
Makefile ASoC: tegra: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:34 +09:00
tegra20_ac97.c ASoC: tegra: tegra20_ac97: Convert to use GPIO descriptors 2023-12-18 14:03:32 +00:00
tegra20_ac97.h ASoC: tegra: tegra20_ac97: Convert to use GPIO descriptors 2023-12-18 14:03:32 +00:00
tegra20_das.c ASoC: tegra: tegra20_das: Drop write-only driver data member 2022-07-05 19:54:00 +01:00
tegra20_i2s.c ASoC: tegra: merge DAI call back functions into ops 2023-08-14 13:10:18 +01:00
tegra20_i2s.h
tegra20_spdif.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra20_spdif.h
tegra30_ahub.c ASoC: tegra: tegra30_ahub: Convert to platform remove callback returning void 2023-03-20 13:09:24 +00:00
tegra30_ahub.h
tegra30_i2s.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra30_i2s.h
tegra186_asrc.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra186_asrc.h ASoC: tegra: Add Tegra186 based ASRC driver 2022-04-04 08:39:14 +01:00
tegra186_dspk.c ASoC: tegra: Fix DSPK 16-bit playback 2024-04-08 13:38:46 +01:00
tegra186_dspk.h
tegra210_admaif.c ASoC: tegra: merge DAI call back functions into ops 2023-08-14 13:10:18 +01:00
tegra210_admaif.h
tegra210_adx.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_adx.h
tegra210_ahub.c ASoC: tegra: Fix CBB error during probe() 2024-08-23 23:07:55 +01:00
tegra210_ahub.h ASoC: tegra: Update AHUB driver for Tegra234 2022-01-28 13:05:26 +00:00
tegra210_amx.c ASoC: tegra: Fix -Wuninitialized in tegra210_amx_platform_probe() 2023-10-12 13:04:55 +01:00
tegra210_amx.h
tegra210_dmic.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_dmic.h
tegra210_i2s.c ASoC: tegra: I2S client convert formats handling 2024-05-27 13:59:49 +01:00
tegra210_i2s.h ASoC: tegra: I2S client convert formats handling 2024-05-27 13:59:49 +01:00
tegra210_mbdrc.c ASoC: tegra: Fix spelling mistake "fliter" -> "filter" 2022-11-10 17:52:46 +00:00
tegra210_mbdrc.h ASoC: tegra: Fix spelling mistake "fliter" -> "filter" 2022-11-10 17:52:46 +00:00
tegra210_mixer.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_mixer.h
tegra210_mvc.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_mvc.h
tegra210_ope.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_ope.h ASoC: tegra: Add Tegra210 based OPE driver 2022-06-06 12:33:07 +01:00
tegra210_peq.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_peq.h ASoC: tegra: Add Tegra210 based OPE driver 2022-06-06 12:33:07 +01:00
tegra210_sfc.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
tegra210_sfc.h ASoC: tegra: Fix SFC conversion for few rates 2023-06-24 01:57:16 +01:00
tegra_asoc_machine.c ASoC: tegra: Use snd_soc_substream_to_rtd() for accessing private_data 2024-05-06 23:59:47 +09:00
tegra_asoc_machine.h
tegra_audio_graph_card.c ASoC: simple-card-utils: Make simple_util_remove() return void 2023-10-23 13:29:45 +01:00
tegra_cif.h
tegra_pcm.c ASoC: tegra: Use snd_soc_substream_to_rtd() for accessing private_data 2024-05-06 23:59:47 +09:00
tegra_pcm.h
tegra_wm8903.c ASoC: tegra: convert not to use asoc_xxx() 2023-09-25 14:16:30 +02:00