mirror of https://github.com/torvalds/linux.git
76818cdd11
According to the KMS man page, there is a "Coverage" alpha blend mode that assumes the pixel color values have NOT been pre-multiplied and will be done when the actual blending to the background color values happens. Previously, this mode hasn't been enabled in our driver and it was assumed that all normal overlay planes are pre-multiplied by default. When a 3rd party app is used to input a image in a specific format, e.g. PNG, as a source of a overlay plane to blend with the background primary plane, the pixel color values are not pre-multiplied. So by adding "Coverage" blend mode, our driver will support those cases. Issue fixed: Overlay plane alpha channel blending is incorrect Issue tracker: https://gitlab.freedesktop.org/drm/amd/-/issues/1769 Reference: https://dri.freedesktop.org/docs/drm/gpu/drm-kms.html#plane-composition-properties Adding Coverage support also enables IGT kms_plane_alpha_blend Coverage subtests: 1. coverage-7efc 2. coverage-vs-premult-vs-constant Changes 1. Add DRM_MODE_BLEND_COVERAGE blend mode capability 2. Add "pre_multiplied_alpha" flag for Coverage case 3. Read the correct flag and set the DCN MPCC pre_multiplied register bit (only on overlay plane) Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1769 Signed-off-by: Sung Joon Kim <Sungjoon.Kim@amd.com> Reviewed-by: Melissa Wen <mwen@igalia.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| dcn10_cm_common.c | ||
| dcn10_cm_common.h | ||
| dcn10_dpp.c | ||
| dcn10_dpp.h | ||
| dcn10_dpp_cm.c | ||
| dcn10_dpp_dscl.c | ||
| dcn10_dwb.c | ||
| dcn10_dwb.h | ||
| dcn10_hubbub.c | ||
| dcn10_hubbub.h | ||
| dcn10_hubp.c | ||
| dcn10_hubp.h | ||
| dcn10_hw_sequencer.c | ||
| dcn10_hw_sequencer.h | ||
| dcn10_hw_sequencer_debug.c | ||
| dcn10_hw_sequencer_debug.h | ||
| dcn10_init.c | ||
| dcn10_init.h | ||
| dcn10_ipp.c | ||
| dcn10_ipp.h | ||
| dcn10_link_encoder.c | ||
| dcn10_link_encoder.h | ||
| dcn10_mpc.c | ||
| dcn10_mpc.h | ||
| dcn10_opp.c | ||
| dcn10_opp.h | ||
| dcn10_optc.c | ||
| dcn10_optc.h | ||
| dcn10_resource.c | ||
| dcn10_resource.h | ||
| dcn10_stream_encoder.c | ||
| dcn10_stream_encoder.h | ||