linux/net/openvswitch
Xin Long 1063ae0738 Revert "openvswitch: switch to per-action label counting in conntrack"
Currently, ovs_ct_set_labels() is only called for confirmed conntrack
entries (ct) within ovs_ct_commit(). However, if the conntrack entry
does not have the labels_ext extension, attempting to allocate it in
ovs_ct_get_conn_labels() for a confirmed entry triggers a warning in
nf_ct_ext_add():

  WARN_ON(nf_ct_is_confirmed(ct));

This happens when the conntrack entry is created externally before OVS
increments net->ct.labels_used. The issue has become more likely since
commit fcb1aa5163 ("openvswitch: switch to per-action label counting
in conntrack"), which changed to use per-action label counting and
increment net->ct.labels_used when a flow with ct action is added.

Since there’s no straightforward way to fully resolve this issue at the
moment, this reverts the commit to avoid breaking existing use cases.

Fixes: fcb1aa5163 ("openvswitch: switch to per-action label counting in conntrack")
Reported-by: Jianbo Liu <jianbol@nvidia.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Aaron Conole <aconole@redhat.com>
Link: https://patch.msgid.link/1bdeb2f3a812bca016a225d3de714427b2cd4772.1741457143.git.lucien.xin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2025-03-13 10:29:34 +01:00
..
Kconfig net: openvswitch: add psample action 2024-07-05 17:45:47 -07:00
Makefile
actions.c openvswitch: fix lockup on tx to unregistering netdev with carrier 2025-01-10 18:20:49 -08:00
conntrack.c Revert "openvswitch: switch to per-action label counting in conntrack" 2025-03-13 10:29:34 +01:00
conntrack.h
datapath.c openvswitch: use RCU protection in ovs_vport_cmd_fill_info() 2025-02-10 18:09:09 -08:00
datapath.h Revert "openvswitch: switch to per-action label counting in conntrack" 2025-03-13 10:29:34 +01:00
dp_notify.c
drop.h
flow.c
flow.h
flow_netlink.c net: openvswitch: remove misbehaving actions length check 2025-03-13 10:29:18 +01:00
flow_netlink.h
flow_table.c
flow_table.h
meter.c
meter.h
openvswitch_trace.c
openvswitch_trace.h
vport-geneve.c
vport-gre.c
vport-internal_dev.c openvswitch: Pass on secpath details for internal port rx. 2024-11-05 17:38:25 -08:00
vport-internal_dev.h
vport-netdev.c
vport-netdev.h
vport-vxlan.c
vport.c net: openvswitch: store sampling probability in cb. 2024-07-05 17:45:47 -07:00
vport.h