Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

landlock: Remove incorrect warning 

landlock_put_hierarchy() can be called when an error occurs in
landlock_merge_ruleset() due to insufficient memory.  In this case, the
domain's audit details might not have been allocated yet, which would
cause landlock_free_hierarchy_details() to print a warning (but still
safely handle this case).

We could keep the WARN_ON_ONCE(!hierarchy) but it's not worth it for
this kind of function, so let's remove it entirely.

Cc: Paul Moore <paul@paul-moore.com>
Reported-by: syzbot+8bca99e91de7e060e4ea@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20250331104709.897062-1-mic@digikod.net
Reviewed-by: Günther Noack <gnoack@google.com>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
This commit is contained in:
Mickaël Salaün 2025-03-31 12:47:07 +02:00
parent 0af2f6be1b
commit fe81536af3
No known key found for this signature in database
GPG Key ID: E5E3D0E88C82F6D2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
security/landlock/domain.h
View File

@ -130,7 +130,7 @@ int landlock_init_hierarchy_log(struct landlock_hierarchy *const hierarchy);
static inline void static inline void
landlock_free_hierarchy_details(struct landlock_hierarchy *const hierarchy) landlock_free_hierarchy_details(struct landlock_hierarchy *const hierarchy)
{ {
if (WARN_ON_ONCE(!hierarchy || !hierarchy->details)) if (!hierarchy || !hierarchy->details)
return; return;
put_pid(hierarchy->details->pid); put_pid(hierarchy->details->pid);