Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ASoC: SDCA: Use helper macros for control identification 

We have the SDCA_CTL_TYPE helper macros, we should use them when
identifying specific controls to simplify the code a little.

Tested-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tested-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20251120153023.2105663-8-ckeepax@opensource.cirrus.com
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Charles Keepax 2025-11-20 15:30:16 +00:00 committed by Mark Brown
parent edb82534ee
commit fb62da31fa
1 changed files with 14 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
sound/soc/sdca/sdca_interrupts.c
View File

@ -456,11 +456,8 @@ int sdca_irq_populate_early(struct device *dev, struct regmap *regmap,
else if (!interrupt)
continue;
switch (entity->type) {
case SDCA_ENTITY_TYPE_XU:
if (control->sel != SDCA_CTL_XU_FDL_CURRENTOWNER)
break;
switch (SDCA_CTL_TYPE(entity->type, control->sel)) {
case SDCA_CTL_TYPE_S(XU, FDL_CURRENTOWNER):
ret = sdca_irq_data_populate(dev, regmap, NULL,
function, entity,
control, interrupt);
@ -534,27 +531,22 @@ int sdca_irq_populate(struct sdca_function_data *function,
handler = base_handler;
switch (entity->type) {
case SDCA_ENTITY_TYPE_ENTITY_0:
if (control->sel == SDCA_CTL_ENTITY_0_FUNCTION_STATUS)
handler = function_status_handler;
switch (SDCA_CTL_TYPE(entity->type, control->sel)) {
case SDCA_CTL_TYPE_S(ENTITY_0, FUNCTION_STATUS):
handler = function_status_handler;
break;
case SDCA_ENTITY_TYPE_GE:
if (control->sel == SDCA_CTL_GE_DETECTED_MODE)
handler = detected_mode_handler;
case SDCA_CTL_TYPE_S(GE, DETECTED_MODE):
handler = detected_mode_handler;
break;
case SDCA_ENTITY_TYPE_XU:
if (control->sel == SDCA_CTL_XU_FDL_CURRENTOWNER) {
ret = sdca_fdl_alloc_state(interrupt);
if (ret)
return ret;
case SDCA_CTL_TYPE_S(XU, FDL_CURRENTOWNER):
ret = sdca_fdl_alloc_state(interrupt);
if (ret)
return ret;
handler = fdl_owner_handler;
}
handler = fdl_owner_handler;
break;
case SDCA_ENTITY_TYPE_HIDE:
if (control->sel == SDCA_CTL_HIDE_HIDTX_CURRENTOWNER)
handler = hid_handler;
case SDCA_CTL_TYPE_S(HIDE, HIDTX_CURRENTOWNER):
handler = hid_handler;
break;
default:
break;