Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

regulator: rt5133: Fix IS_ERR() vs NULL bug in rt5133_validate_vendor_info() 

The "priv->cdata" pointer isn't an error pointer; this should be a NULL
check instead.  Otherwise it leads to a NULL pointer dereference in the
caller, rt5133_probe().

Fixes: 714165e1c4 ("regulator: rt5133: Add RT5133 PMIC regulator Support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aKMc1oK-7yY4cD3K@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Dan Carpenter 2025-08-18 15:30:14 +03:00 committed by Mark Brown
parent 550bc517e5
commit f7f804633c
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/regulator/rt5133-regulator.c
View File

@ -510,7 +510,7 @@ static int rt5133_validate_vendor_info(struct rt5133_priv *priv)
break; break;
} }
} }
if (IS_ERR(priv->cdata)) { if (!priv->cdata) {
dev_err(priv->dev, "Failed to find regulator match version\n"); dev_err(priv->dev, "Failed to find regulator match version\n");
return -ENODEV; return -ENODEV;
} }