Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

nfsdfs_create_files(): switch to simple_start_creating() 

Reviewed-by: NeilBrown <neil@brown.name>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2025-07-02 03:30:58 -04:00
parent a6281a7043
commit e59f06bb5d
1 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
fs/nfsd/nfsctl.c
View File

@ -1216,40 +1216,34 @@ struct nfsdfs_client *get_nfsdfs_client(struct inode *inode)
/* XXX: cut'n'paste from simple_fill_super; figure out if we could share /* XXX: cut'n'paste from simple_fill_super; figure out if we could share
* code instead. */ * code instead. */
static int nfsdfs_create_files(struct dentry *root, static int nfsdfs_create_files(struct dentry *root,
const struct tree_descr *files, const struct tree_descr *files,
struct nfsdfs_client *ncl, struct nfsdfs_client *ncl,
struct dentry **fdentries) struct dentry **fdentries)
{ {
struct inode *dir = d_inode(root); struct inode *dir = d_inode(root);
struct inode *inode;
struct dentry *dentry; struct dentry *dentry;
int i;
inode_lock(dir); for (int i = 0; files->name && files->name[0]; i++, files++) {
for (i = 0; files->name && files->name[0]; i++, files++) { struct inode *inode = nfsd_get_inode(root->d_sb,
dentry = d_alloc_name(root, files->name); S_IFREG | files->mode);
if (!dentry) if (!inode)
goto out; return -ENOMEM;
inode = nfsd_get_inode(d_inode(root)->i_sb, dentry = simple_start_creating(root, files->name);
S_IFREG | files->mode); if (IS_ERR(dentry)) {
if (!inode) { iput(inode);
dput(dentry); return PTR_ERR(dentry);
goto out;
} }
kref_get(&ncl->cl_ref); kref_get(&ncl->cl_ref);
inode->i_fop = files->ops; inode->i_fop = files->ops;
inode->i_private = ncl; inode->i_private = ncl;
d_add(dentry, inode); d_instantiate(dentry, inode);
fsnotify_create(dir, dentry); fsnotify_create(dir, dentry);
if (fdentries) if (fdentries)
fdentries[i] = dentry; fdentries[i] = dentry;
inode_unlock(dir);
} }
inode_unlock(dir);
return 0; return 0;
out:
inode_unlock(dir);
return -ENOMEM;
} }
/* on success, returns positive number unique to that client. */ /* on success, returns positive number unique to that client. */