Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mailbox: th1520: fix clock imbalance on probe failure 

The purpose of the devm_add_action_or_reset() helper is to call the
action function in case adding an action ever fails so drop the clock
disable from the error path to avoid disabling the clocks twice.

Fixes: 5d4d263e1c ("mailbox: Introduce support for T-head TH1520 Mailbox driver")
Cc: Michal Wilczynski <m.wilczynski@samsung.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
This commit is contained in:
Johan Hovold 2025-10-17 07:54:14 +02:00 committed by Jassi Brar
parent ff0e4d4c97
commit e3cee98f2f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mailbox/mailbox-th1520.c
View File

@ -435,10 +435,8 @@ static int th1520_mbox_probe(struct platform_device *pdev)
} }
ret = devm_add_action_or_reset(dev, th1520_disable_clk, priv); ret = devm_add_action_or_reset(dev, th1520_disable_clk, priv);
if (ret) { if (ret)
clk_bulk_disable_unprepare(ARRAY_SIZE(priv->clocks), priv->clocks);
return ret; return ret;
}
/* /*
* The address mappings in the device tree align precisely with those * The address mappings in the device tree align precisely with those