Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

docs: submitting-patches: Clarify that removal of Acks needs explanation too 

The paragraph mentions only removal of Tested-by and Reviewed-by tags as
action needing mentioning in patch changelog, so some developers treat
it too literally.  Acks, as a weaker form of review/approval, should
rarely be removed, but if that happens it should be explained as well.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Message-ID: <20251126081905.7684-2-krzysztof.kozlowski@oss.qualcomm.com>
This commit is contained in:
Krzysztof Kozlowski 2025-11-26 09:19:06 +01:00 committed by Jonathan Corbet
parent 2006f468bb
commit e36a7b1e17
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/process/submitting-patches.rst
View File

@ -592,8 +592,9 @@ Both Tested-by and Reviewed-by tags, once received on mailing list from tester
or reviewer, should be added by author to the applicable patches when sending or reviewer, should be added by author to the applicable patches when sending
next versions. However if the patch has changed substantially in following next versions. However if the patch has changed substantially in following
version, these tags might not be applicable anymore and thus should be removed. version, these tags might not be applicable anymore and thus should be removed.
Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned Usually removal of someone's Acked-by, Tested-by or Reviewed-by tags should be
in the patch changelog (after the '---' separator). mentioned in the patch changelog with an explanation (after the '---'
separator).
A Suggested-by: tag indicates that the patch idea is suggested by the person A Suggested-by: tag indicates that the patch idea is suggested by the person
named and ensures credit to the person for the idea: if we diligently credit named and ensures credit to the person for the idea: if we diligently credit