Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rtla: Fix -a overriding -t argument 

When running rtla as

    `rtla <timerlat|osnoise> <top|hist> -t custom_file.txt -a 100`

-a options override trace output filename specified by -t option.
Running the command above will create <timerlat|osnoise>_trace.txt file
instead of custom_file.txt. Fix this by making sure that -a option does
not override trace output filename even if it's passed after trace
output filename is specified.

Fixes: 173a3b0148 ("rtla/timerlat: Add the automatic trace option")
Signed-off-by: Ivan Pravdin <ipravdin.official@gmail.com>
Reviewed-by: Tomas Glozar <tglozar@redhat.com>
Link: https://lore.kernel.org/r/b6ae60424050b2c1c8709e18759adead6012b971.1762186418.git.ipravdin.official@gmail.com
[ use capital letter in subject, as required by tracing subsystem ]
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
This commit is contained in:
Ivan Pravdin 2025-11-03 11:19:08 -05:00 committed by Tomas Glozar
parent 7b71f3a698
commit ddb6e42494
4 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/tracing/rtla/src/osnoise_hist.c
View File

@ -534,7 +534,8 @@ static struct common_params
params->threshold = 1;
/* set trace */
trace_output = "osnoise_trace.txt";
if (!trace_output)
trace_output = "osnoise_trace.txt";
break;
case 'b':

3
tools/tracing/rtla/src/osnoise_top.c
View File

@ -386,7 +386,8 @@ struct common_params *osnoise_top_parse_args(int argc, char **argv)
params->threshold = 1;
/* set trace */
trace_output = "osnoise_trace.txt";
if (!trace_output)
trace_output = "osnoise_trace.txt";
break;
case 'c':

3
tools/tracing/rtla/src/timerlat_hist.c
View File

@ -853,7 +853,8 @@ static struct common_params
params->print_stack = auto_thresh;
/* set trace */
trace_output = "timerlat_trace.txt";
if (!trace_output)
trace_output = "timerlat_trace.txt";
break;
case 'c':

3
tools/tracing/rtla/src/timerlat_top.c
View File

@ -617,7 +617,8 @@ static struct common_params
params->print_stack = auto_thresh;
/* set trace */
trace_output = "timerlat_trace.txt";
if (!trace_output)
trace_output = "timerlat_trace.txt";
break;
case '5':