Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ALSA: firewire-tascam: reserve resources for transferred isochronous packets at S400 

TASCAM FW-1884/FW-1804/FW-1082 have a quirk that they often freeze when
receiving isochronous packets at S400. This behaviour is suppressed by a
new quirk flag added in Linux FireWire core to restrict maximum speed.
Consequently both of the asynchronous transactions and isochronous
transmissions are done at S200. However, the device still transfers
isochronous packet at S400, and the way to indicate the transmission
speed is not cleared yet.

This commit correctly reserves isochronous resources for the transferred
packet stream at S400. As a beneficial side effect, the pair of
isochronous transmissions for FW-1884 fits within the bandwidth capacity
of the bus.

Link: https://lore.kernel.org/r/20251018035532.287124-5-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2025-10-18 12:55:32 +09:00
parent d52bb3daad
commit dbd0cf204f
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sound/firewire/tascam/tascam-stream.c
View File

@ -282,20 +282,22 @@ static int keep_resources(struct snd_tscm *tscm, unsigned int rate,
struct amdtp_stream *stream) struct amdtp_stream *stream)
{ {
struct fw_iso_resources *resources; struct fw_iso_resources *resources;
int speed;
int err; int err;
if (stream == &tscm->tx_stream) if (stream == &tscm->tx_stream) {
resources = &tscm->tx_resources; resources = &tscm->tx_resources;
else speed = fw_parent_device(tscm->unit)->max_speed;
} else {
resources = &tscm->rx_resources; resources = &tscm->rx_resources;
speed = SCODE_400;
}
err = amdtp_tscm_set_parameters(stream, rate); err = amdtp_tscm_set_parameters(stream, rate);
if (err < 0) if (err < 0)
return err; return err;
return fw_iso_resources_allocate(resources, return fw_iso_resources_allocate(resources, amdtp_stream_get_max_payload(stream), speed);
amdtp_stream_get_max_payload(stream),
fw_parent_device(tscm->unit)->max_speed);
} }
static int init_stream(struct snd_tscm *tscm, struct amdtp_stream *s) static int init_stream(struct snd_tscm *tscm, struct amdtp_stream *s)
@ -455,7 +457,6 @@ int snd_tscm_stream_start_duplex(struct snd_tscm *tscm, unsigned int rate)
} }
if (!amdtp_stream_running(&tscm->rx_stream)) { if (!amdtp_stream_running(&tscm->rx_stream)) {
int spd = fw_parent_device(tscm->unit)->max_speed;
unsigned int tx_init_skip_cycles; unsigned int tx_init_skip_cycles;
err = set_stream_formats(tscm, rate); err = set_stream_formats(tscm, rate);
@ -466,13 +467,13 @@ int snd_tscm_stream_start_duplex(struct snd_tscm *tscm, unsigned int rate)
if (err < 0) if (err < 0)
goto error; goto error;
err = amdtp_domain_add_stream(&tscm->domain, &tscm->rx_stream, err = amdtp_domain_add_stream(&tscm->domain, &tscm->rx_stream, tscm->rx_resources.channel,
tscm->rx_resources.channel, spd); fw_parent_device(tscm->unit)->max_speed);
if (err < 0) if (err < 0)
goto error; goto error;
err = amdtp_domain_add_stream(&tscm->domain, &tscm->tx_stream, err = amdtp_domain_add_stream(&tscm->domain, &tscm->tx_stream, tscm->tx_resources.channel,
tscm->tx_resources.channel, spd); SCODE_400);
if (err < 0) if (err < 0)
goto error; goto error;