Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ASoC: amd: use int type to store negative error codes 

Change the 'ret' variable from u32 to int to store negative error codes
directly or returned by other functions.

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Message-ID: <20250828075406.386208-2-rongqianfeng@vivo.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Qianfeng Rong 2025-08-28 15:53:57 +08:00 committed by Mark Brown
parent 1b237f190e
commit d985b60f47
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/soc/amd/acp/acp-rembrandt.c
View File

@ -147,7 +147,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct acp_chip_info *chip;
u32 ret;
int ret;
chip = dev_get_platdata(&pdev->dev);
if (!chip || !chip->base) {

3
sound/soc/amd/raven/acp3x-i2s.c
View File

@ -149,8 +149,9 @@ static int acp3x_i2s_trigger(struct snd_pcm_substream *substream,
int cmd, struct snd_soc_dai *dai)
{
struct i2s_stream_instance *rtd;
u32 ret, val, period_bytes, reg_val, ier_val, water_val;
u32 val, period_bytes, reg_val, ier_val, water_val;
u32 buf_size, buf_reg;
int ret;
rtd = substream->runtime->private_data;
period_bytes = frames_to_bytes(substream->runtime,

3
sound/soc/amd/vangogh/acp5x-i2s.c
View File

@ -234,8 +234,9 @@ static int acp5x_i2s_trigger(struct snd_pcm_substream *substream,
{
struct i2s_stream_instance *rtd;
struct i2s_dev_data *adata;
u32 ret, val, period_bytes, reg_val, ier_val, water_val;
u32 val, period_bytes, reg_val, ier_val, water_val;
u32 buf_size, buf_reg;
int ret;
adata = snd_soc_dai_get_drvdata(dai);
rtd = substream->runtime->private_data;