Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

power: reset: reboot-mode: fix -Wformat-security warning 

The device_create() function expects a format string to construct a device
name, so passing a variable here introduces a possible vulnerability in
case the string can contain '%' characters:

drivers/power/reset/reboot-mode.c:148:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
drivers/power/reset/reboot-mode.c:148:22: note: treat the string as an argument to avoid this
  148 |                                                  (void *)priv, reboot->dev->driver->name);

Use an trivial "%s" format instead and pass the name as the string to be
included here.

Fixes: cfaf0a9078 ("power: reset: reboot-mode: Expose sysfs for registered reboot_modes")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260306150738.497978-1-arnd@kernel.org
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Arnd Bergmann 2026-03-06 16:07:34 +01:00 committed by Sebastian Reichel
parent 2cfc7cac68
commit c7e05ab38a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/power/reset/reboot-mode.c
View File

@ -145,7 +145,8 @@ static int reboot_mode_create_device(struct reboot_mode_driver *reboot)
}
priv->reboot_mode_device = device_create(&reboot_mode_class, NULL, 0,
(void *)priv, reboot->dev->driver->name);
(void *)priv, "%s",
reboot->dev->driver->name);
if (IS_ERR(priv->reboot_mode_device)) {
ret = PTR_ERR(priv->reboot_mode_device);
goto error;