Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init() 

The devm_auxiliary_device_create() returns NULL on error.  It never
returns error pointers.  Using PTR_ERR_OR_ZERO() here means the function
always returns success.  Replace the PTR_ERR_OR_ZERO() call check with
a NULL check.

Fixes: 64581f41f4 ("pmdomain: thead: create auxiliary device for rebooting")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Dan Carpenter 2025-09-26 07:03:29 +03:00 committed by Ulf Hansson
parent de023206fc
commit bbc3110823
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pmdomain/thead/th1520-pm-domains.c
View File

@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev,
struct auxiliary_device *adev;
adev = devm_auxiliary_device_create(dev, "reboot", aon_chan);
if (!adev)
return -ENODEV;
return PTR_ERR_OR_ZERO(adev);
return 0;
}
static int th1520_pd_probe(struct platform_device *pdev)