Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

USB: lower "Device is not authorized for usage" message to info 

This message is not a useful error in practice:
- when using tools such as usbguard, the message is always printed but
  it does not presume anything regarding the actual device acceptance
  (later 'authorized to connect' message is at info level, and not
   displayed on console)
- this can be a source of flood if a usb device connection is flaky
- ... and it is only displayed as the result of an admin action
  (modifying authorized_default), working as intended, so not likely
  to be an error.

This is still useful to know when looking at usb devices problems, so
info seems appropriate for this class of messages together with the
later eventual authorized message.

Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
Link: https://lore.kernel.org/r/20250801-usb-auth-v1-1-a59bfdf0293f@atmark-techno.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dominique Martinet 2025-08-01 16:52:02 +09:00 committed by Greg Kroah-Hartman
parent 015709748c
commit b12daf363f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/core/driver.c
View File

@ -332,10 +332,10 @@ static int usb_probe_interface(struct device *dev)
return error; return error;
if (udev->authorized == 0) { if (udev->authorized == 0) {
dev_err(&intf->dev, "Device is not authorized for usage\n"); dev_info(&intf->dev, "Device is not authorized for usage\n");
return error; return error;
} else if (intf->authorized == 0) { } else if (intf->authorized == 0) {
dev_err(&intf->dev, "Interface %d is not authorized for usage\n", dev_info(&intf->dev, "Interface %d is not authorized for usage\n",
intf->altsetting->desc.bInterfaceNumber); intf->altsetting->desc.bInterfaceNumber);
return error; return error;
} }

2
drivers/usb/core/generic.c
View File

@ -243,7 +243,7 @@ int usb_generic_driver_probe(struct usb_device *udev)
* with the driver core and lets interface drivers bind to them. * with the driver core and lets interface drivers bind to them.
*/ */
if (udev->authorized == 0) if (udev->authorized == 0)
dev_err(&udev->dev, "Device is not authorized for usage\n"); dev_info(&udev->dev, "Device is not authorized for usage\n");
else { else {
c = usb_choose_configuration(udev); c = usb_choose_configuration(udev);
if (c >= 0) { if (c >= 0) {