Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

media: venus: pm_helpers: add fallback for the opp-table 

Since the device trees for both HFI_VERSION_1XX and HFI_VERSION_3XX
do not include an opp-table and have not configured opp-pmdomain, they
still need to use the frequencies defined in the driver's freq_tbl.

Both core_power_v1 and core_power_v4 functions require core_clks_enable
function during POWER_ON. Therefore, in the core_clks_enable function,
if calling dev_pm_opp_find_freq_ceil to obtain the frequency fails,
it needs to fall back to the freq_tbl to retrieve the frequency.

Fixes: b179234b5e ("media: venus: pm_helpers: use opp-table for the frequency")
Cc: stable@vger.kernel.org
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Closes: https://lore.kernel.org/linux-media/CA+G9fYu5=3n84VY+vTbCAcfFKOq7Us5vgBZgpypY4MveM=eVwg@mail.gmail.com
Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
This commit is contained in:
Renjiang Han 2025-09-18 17:31:08 +05:30 committed by Hans Verkuil
parent 94662f560b
commit afb100a5ea
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/platform/qcom/venus/pm_helpers.c
View File

@ -40,6 +40,8 @@ static int core_clks_get(struct venus_core *core)
static int core_clks_enable(struct venus_core *core) static int core_clks_enable(struct venus_core *core)
{ {
const struct freq_tbl *freq_tbl = core->res->freq_tbl;
unsigned int freq_tbl_size = core->res->freq_tbl_size;
const struct venus_resources *res = core->res; const struct venus_resources *res = core->res;
struct device *dev = core->dev; struct device *dev = core->dev;
unsigned long freq = 0; unsigned long freq = 0;
@ -48,8 +50,13 @@ static int core_clks_enable(struct venus_core *core)
int ret; int ret;
opp = dev_pm_opp_find_freq_ceil(dev, &freq); opp = dev_pm_opp_find_freq_ceil(dev, &freq);
if (!IS_ERR(opp)) if (IS_ERR(opp)) {
if (!freq_tbl)
return -ENODEV;
freq = freq_tbl[freq_tbl_size - 1].freq;
} else {
dev_pm_opp_put(opp); dev_pm_opp_put(opp);
}
for (i = 0; i < res->clks_num; i++) { for (i = 0; i < res->clks_num; i++) {
if (IS_V6(core) || (IS_V4(core) && is_lite(core))) { if (IS_V6(core) || (IS_V4(core) && is_lite(core))) {