Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

i2c: Remove redundant pm_runtime_mark_last_busy() calls 

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
This commit is contained in:
Sakari Ailus 2025-07-04 10:54:15 +03:00 committed by Wolfram Sang
parent 3a86608788
commit ae11e08c3d
22 changed files with 0 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/i2c/busses/i2c-amd-mp2.h
View File

@ -207,7 +207,6 @@ static inline void amd_mp2_pm_runtime_get(struct amd_mp2_dev *mp2_dev)
static inline void amd_mp2_pm_runtime_put(struct amd_mp2_dev *mp2_dev) static inline void amd_mp2_pm_runtime_put(struct amd_mp2_dev *mp2_dev)
{ {
pm_runtime_mark_last_busy(&mp2_dev->pci_dev->dev);
pm_runtime_put_autosuspend(&mp2_dev->pci_dev->dev); pm_runtime_put_autosuspend(&mp2_dev->pci_dev->dev);
} }

1
drivers/i2c/busses/i2c-at91-core.c
View File

@ -313,7 +313,6 @@ static int __maybe_unused at91_twi_resume_noirq(struct device *dev)
return ret; return ret;
} }
pm_runtime_mark_last_busy(dev);
pm_request_autosuspend(dev); pm_request_autosuspend(dev);
at91_init_twi_bus(twi_dev); at91_init_twi_bus(twi_dev);

1
drivers/i2c/busses/i2c-at91-master.c
View File

@ -717,7 +717,6 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)
ret = (ret < 0) ? ret : num; ret = (ret < 0) ? ret : num;
out: out:
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev); pm_runtime_put_autosuspend(dev->dev);
return ret; return ret;

1
drivers/i2c/busses/i2c-cadence.c
View File

@ -1128,7 +1128,6 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
cdns_i2c_set_mode(CDNS_I2C_MODE_SLAVE, id); cdns_i2c_set_mode(CDNS_I2C_MODE_SLAVE, id);
#endif #endif
pm_runtime_mark_last_busy(id->dev);
pm_runtime_put_autosuspend(id->dev); pm_runtime_put_autosuspend(id->dev);
return ret; return ret;
} }

2
drivers/i2c/busses/i2c-davinci.c
View File

@ -543,7 +543,6 @@ i2c_davinci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
ret = num; ret = num;
out: out:
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev); pm_runtime_put_autosuspend(dev->dev);
return ret; return ret;
@ -821,7 +820,6 @@ static int davinci_i2c_probe(struct platform_device *pdev)
if (r) if (r)
goto err_unuse_clocks; goto err_unuse_clocks;
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev); pm_runtime_put_autosuspend(dev->dev);
return 0; return 0;

1
drivers/i2c/busses/i2c-designware-master.c
View File

@ -901,7 +901,6 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
i2c_dw_release_lock(dev); i2c_dw_release_lock(dev);
done_nolock: done_nolock:
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev); pm_runtime_put_autosuspend(dev->dev);
return ret; return ret;

1
drivers/i2c/busses/i2c-hix5hd2.c
View File

@ -373,7 +373,6 @@ static int hix5hd2_i2c_xfer(struct i2c_adapter *adap,
ret = num; ret = num;
out: out:
pm_runtime_mark_last_busy(priv->dev);
pm_runtime_put_autosuspend(priv->dev); pm_runtime_put_autosuspend(priv->dev);
return ret; return ret;
} }

1
drivers/i2c/busses/i2c-i801.c
View File

@ -930,7 +930,6 @@ static s32 i801_access(struct i2c_adapter *adap, u16 addr,
*/ */
iowrite8(SMBHSTSTS_INUSE_STS | STATUS_FLAGS, SMBHSTSTS(priv)); iowrite8(SMBHSTSTS_INUSE_STS | STATUS_FLAGS, SMBHSTSTS(priv));
pm_runtime_mark_last_busy(&priv->pci_dev->dev);
pm_runtime_put_autosuspend(&priv->pci_dev->dev); pm_runtime_put_autosuspend(&priv->pci_dev->dev);
return ret; return ret;
} }

3
drivers/i2c/busses/i2c-img-scb.c
View File

@ -1131,7 +1131,6 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
break; break;
} }
pm_runtime_mark_last_busy(adap->dev.parent);
pm_runtime_put_autosuspend(adap->dev.parent); pm_runtime_put_autosuspend(adap->dev.parent);
return i2c->msg_status ? i2c->msg_status : num; return i2c->msg_status ? i2c->msg_status : num;
@ -1165,7 +1164,6 @@ static int img_i2c_init(struct img_i2c *i2c)
"Unknown hardware revision (%d.%d.%d.%d)\n", "Unknown hardware revision (%d.%d.%d.%d)\n",
(rev >> 24) & 0xff, (rev >> 16) & 0xff, (rev >> 24) & 0xff, (rev >> 16) & 0xff,
(rev >> 8) & 0xff, rev & 0xff); (rev >> 8) & 0xff, rev & 0xff);
pm_runtime_mark_last_busy(i2c->adap.dev.parent);
pm_runtime_put_autosuspend(i2c->adap.dev.parent); pm_runtime_put_autosuspend(i2c->adap.dev.parent);
return -EINVAL; return -EINVAL;
} }
@ -1317,7 +1315,6 @@ static int img_i2c_init(struct img_i2c *i2c)
/* Perform a synchronous sequence to reset the bus */ /* Perform a synchronous sequence to reset the bus */
ret = img_i2c_reset_bus(i2c); ret = img_i2c_reset_bus(i2c);
pm_runtime_mark_last_busy(i2c->adap.dev.parent);
pm_runtime_put_autosuspend(i2c->adap.dev.parent); pm_runtime_put_autosuspend(i2c->adap.dev.parent);
return ret; return ret;

4
drivers/i2c/busses/i2c-imx-lpi2c.c
View File

@ -363,7 +363,6 @@ static int lpi2c_imx_master_enable(struct lpi2c_imx_struct *lpi2c_imx)
return 0; return 0;
rpm_put: rpm_put:
pm_runtime_mark_last_busy(lpi2c_imx->adapter.dev.parent);
pm_runtime_put_autosuspend(lpi2c_imx->adapter.dev.parent); pm_runtime_put_autosuspend(lpi2c_imx->adapter.dev.parent);
return ret; return ret;
@ -377,7 +376,6 @@ static int lpi2c_imx_master_disable(struct lpi2c_imx_struct *lpi2c_imx)
temp &= ~MCR_MEN; temp &= ~MCR_MEN;
writel(temp, lpi2c_imx->base + LPI2C_MCR); writel(temp, lpi2c_imx->base + LPI2C_MCR);
pm_runtime_mark_last_busy(lpi2c_imx->adapter.dev.parent);
pm_runtime_put_autosuspend(lpi2c_imx->adapter.dev.parent); pm_runtime_put_autosuspend(lpi2c_imx->adapter.dev.parent);
return 0; return 0;
@ -1462,7 +1460,6 @@ static int lpi2c_imx_probe(struct platform_device *pdev)
if (ret) if (ret)
goto rpm_disable; goto rpm_disable;
pm_runtime_mark_last_busy(&pdev->dev);
pm_runtime_put_autosuspend(&pdev->dev); pm_runtime_put_autosuspend(&pdev->dev);
dev_info(&lpi2c_imx->adapter.dev, "LPI2C adapter registered\n"); dev_info(&lpi2c_imx->adapter.dev, "LPI2C adapter registered\n");
@ -1564,7 +1561,6 @@ static int lpi2c_suspend(struct device *dev)
static int lpi2c_resume(struct device *dev) static int lpi2c_resume(struct device *dev)
{ {
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return 0; return 0;

3
drivers/i2c/busses/i2c-imx.c
View File

@ -1637,7 +1637,6 @@ static int i2c_imx_xfer(struct i2c_adapter *adapter,
result = i2c_imx_xfer_common(adapter, msgs, num, false); result = i2c_imx_xfer_common(adapter, msgs, num, false);
pm_runtime_mark_last_busy(i2c_imx->adapter.dev.parent);
pm_runtime_put_autosuspend(i2c_imx->adapter.dev.parent); pm_runtime_put_autosuspend(i2c_imx->adapter.dev.parent);
return result; return result;
@ -1822,7 +1821,6 @@ static int i2c_imx_probe(struct platform_device *pdev)
if (ret < 0) if (ret < 0)
goto clk_notifier_unregister; goto clk_notifier_unregister;
pm_runtime_mark_last_busy(&pdev->dev);
pm_runtime_put_autosuspend(&pdev->dev); pm_runtime_put_autosuspend(&pdev->dev);
dev_dbg(&i2c_imx->adapter.dev, "claimed irq %d\n", irq); dev_dbg(&i2c_imx->adapter.dev, "claimed irq %d\n", irq);
@ -1928,7 +1926,6 @@ static int i2c_imx_suspend(struct device *dev)
static int i2c_imx_resume(struct device *dev) static int i2c_imx_resume(struct device *dev)
{ {
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return 0; return 0;

1
drivers/i2c/busses/i2c-mv64xxx.c
View File

@ -766,7 +766,6 @@ mv64xxx_i2c_xfer_core(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
drv_data->num_msgs = 0; drv_data->num_msgs = 0;
drv_data->msgs = NULL; drv_data->msgs = NULL;
pm_runtime_mark_last_busy(&adap->dev);
pm_runtime_put_autosuspend(&adap->dev); pm_runtime_put_autosuspend(&adap->dev);
return ret; return ret;

1
drivers/i2c/busses/i2c-nvidia-gpu.c
View File

@ -216,7 +216,6 @@ static int gpu_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
if (status2 < 0) if (status2 < 0)
dev_err(i2cd->dev, "i2c stop failed %d\n", status2); dev_err(i2cd->dev, "i2c stop failed %d\n", status2);
} }
pm_runtime_mark_last_busy(i2cd->dev);
pm_runtime_put_autosuspend(i2cd->dev); pm_runtime_put_autosuspend(i2cd->dev);
return status; return status;
} }

3
drivers/i2c/busses/i2c-omap.c
View File

@ -828,7 +828,6 @@ omap_i2c_xfer_common(struct i2c_adapter *adap, struct i2c_msg msgs[], int num,
omap->set_mpu_wkup_lat(omap->dev, -1); omap->set_mpu_wkup_lat(omap->dev, -1);
out: out:
pm_runtime_mark_last_busy(omap->dev);
pm_runtime_put_autosuspend(omap->dev); pm_runtime_put_autosuspend(omap->dev);
return r; return r;
} }
@ -1510,7 +1509,6 @@ omap_i2c_probe(struct platform_device *pdev)
dev_info(omap->dev, "bus %d rev%d.%d at %d kHz\n", adap->nr, dev_info(omap->dev, "bus %d rev%d.%d at %d kHz\n", adap->nr,
major, minor, omap->speed); major, minor, omap->speed);
pm_runtime_mark_last_busy(omap->dev);
pm_runtime_put_autosuspend(omap->dev); pm_runtime_put_autosuspend(omap->dev);
return 0; return 0;
@ -1605,7 +1603,6 @@ static int omap_i2c_suspend(struct device *dev)
static int omap_i2c_resume(struct device *dev) static int omap_i2c_resume(struct device *dev)
{ {
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return 0; return 0;

2
drivers/i2c/busses/i2c-qcom-cci.c
View File

@ -450,7 +450,6 @@ static int cci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
ret = num; ret = num;
err: err:
pm_runtime_mark_last_busy(cci->dev);
pm_runtime_put_autosuspend(cci->dev); pm_runtime_put_autosuspend(cci->dev);
return ret; return ret;
@ -508,7 +507,6 @@ static int __maybe_unused cci_suspend(struct device *dev)
static int __maybe_unused cci_resume(struct device *dev) static int __maybe_unused cci_resume(struct device *dev)
{ {
cci_resume_runtime(dev); cci_resume_runtime(dev);
pm_runtime_mark_last_busy(dev);
pm_request_autosuspend(dev); pm_request_autosuspend(dev);
return 0; return 0;

1
drivers/i2c/busses/i2c-qcom-geni.c
View File

@ -714,7 +714,6 @@ static int geni_i2c_xfer(struct i2c_adapter *adap,
else else
ret = geni_i2c_fifo_xfer(gi2c, msgs, num); ret = geni_i2c_fifo_xfer(gi2c, msgs, num);
pm_runtime_mark_last_busy(gi2c->se.dev);
pm_runtime_put_autosuspend(gi2c->se.dev); pm_runtime_put_autosuspend(gi2c->se.dev);
gi2c->cur = NULL; gi2c->cur = NULL;
gi2c->err = 0; gi2c->err = 0;

3
drivers/i2c/busses/i2c-qup.c
View File

@ -1139,7 +1139,6 @@ static int qup_i2c_xfer(struct i2c_adapter *adap,
ret = num; ret = num;
out: out:
pm_runtime_mark_last_busy(qup->dev);
pm_runtime_put_autosuspend(qup->dev); pm_runtime_put_autosuspend(qup->dev);
return ret; return ret;
@ -1624,7 +1623,6 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
if (ret == 0) if (ret == 0)
ret = num; ret = num;
out: out:
pm_runtime_mark_last_busy(qup->dev);
pm_runtime_put_autosuspend(qup->dev); pm_runtime_put_autosuspend(qup->dev);
return ret; return ret;
@ -1991,7 +1989,6 @@ static int qup_i2c_suspend(struct device *device)
static int qup_i2c_resume(struct device *device) static int qup_i2c_resume(struct device *device)
{ {
qup_i2c_pm_resume_runtime(device); qup_i2c_pm_resume_runtime(device);
pm_runtime_mark_last_busy(device);
pm_request_autosuspend(device); pm_request_autosuspend(device);
return 0; return 0;
} }

2
drivers/i2c/busses/i2c-riic.c
View File

@ -206,7 +206,6 @@ static int riic_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
} }
out: out:
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return riic->err ?: num; return riic->err ?: num;
@ -452,7 +451,6 @@ static int riic_init_hw(struct riic_dev *riic)
riic_clear_set_bit(riic, ICCR1_IICRST, 0, RIIC_ICCR1); riic_clear_set_bit(riic, ICCR1_IICRST, 0, RIIC_ICCR1);
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return 0; return 0;
} }

1
drivers/i2c/busses/i2c-rzv2m.c
View File

@ -372,7 +372,6 @@ static int rzv2m_i2c_xfer(struct i2c_adapter *adap,
ret = num; ret = num;
out: out:
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return ret; return ret;

2
drivers/i2c/busses/i2c-sprd.c
View File

@ -302,7 +302,6 @@ static int sprd_i2c_xfer(struct i2c_adapter *i2c_adap,
ret = sprd_i2c_handle_msg(i2c_adap, &msgs[im++], 1); ret = sprd_i2c_handle_msg(i2c_adap, &msgs[im++], 1);
err_msg: err_msg:
pm_runtime_mark_last_busy(i2c_dev->dev);
pm_runtime_put_autosuspend(i2c_dev->dev); pm_runtime_put_autosuspend(i2c_dev->dev);
return ret < 0 ? ret : im; return ret < 0 ? ret : im;
@ -559,7 +558,6 @@ static int sprd_i2c_probe(struct platform_device *pdev)
goto err_rpm_put; goto err_rpm_put;
} }
pm_runtime_mark_last_busy(i2c_dev->dev);
pm_runtime_put_autosuspend(i2c_dev->dev); pm_runtime_put_autosuspend(i2c_dev->dev);
return 0; return 0;

5
drivers/i2c/busses/i2c-stm32f7.c
View File

@ -1761,7 +1761,6 @@ static int stm32f7_i2c_xfer_core(struct i2c_adapter *i2c_adap,
} }
pm_free: pm_free:
pm_runtime_mark_last_busy(i2c_dev->dev);
pm_runtime_put_autosuspend(i2c_dev->dev); pm_runtime_put_autosuspend(i2c_dev->dev);
return (ret < 0) ? ret : num; return (ret < 0) ? ret : num;
@ -1870,7 +1869,6 @@ static int stm32f7_i2c_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
} }
pm_free: pm_free:
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return ret; return ret;
} }
@ -1977,7 +1975,6 @@ static int stm32f7_i2c_reg_slave(struct i2c_client *slave)
if (!stm32f7_i2c_is_slave_registered(i2c_dev)) if (!stm32f7_i2c_is_slave_registered(i2c_dev))
stm32f7_i2c_enable_wakeup(i2c_dev, false); stm32f7_i2c_enable_wakeup(i2c_dev, false);
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev); pm_runtime_put_autosuspend(dev);
return ret; return ret;
@ -2015,7 +2012,6 @@ static int stm32f7_i2c_unreg_slave(struct i2c_client *slave)
stm32f7_i2c_enable_wakeup(i2c_dev, false); stm32f7_i2c_enable_wakeup(i2c_dev, false);
} }
pm_runtime_mark_last_busy(i2c_dev->dev);
pm_runtime_put_autosuspend(i2c_dev->dev); pm_runtime_put_autosuspend(i2c_dev->dev);
return 0; return 0;
@ -2328,7 +2324,6 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
dev_info(i2c_dev->dev, "STM32F7 I2C-%d bus adapter\n", adap->nr); dev_info(i2c_dev->dev, "STM32F7 I2C-%d bus adapter\n", adap->nr);
pm_runtime_mark_last_busy(i2c_dev->dev);
pm_runtime_put_autosuspend(i2c_dev->dev); pm_runtime_put_autosuspend(i2c_dev->dev);
return 0; return 0;

1
drivers/i2c/busses/i2c-xiic.c
View File

@ -1349,7 +1349,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
mutex_unlock(&i2c->lock); mutex_unlock(&i2c->lock);
out: out:
pm_runtime_mark_last_busy(i2c->dev);
pm_runtime_put_autosuspend(i2c->dev); pm_runtime_put_autosuspend(i2c->dev);
return err; return err;
} }