Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ALSA: pcmtest: Replace deprecated strcpy with strscpy_pad in setup_patt_bufs 

strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. Replace
it with the safer strscpy_pad(), and use kmalloc() instead of kzalloc()
because strscpy_pad() zero-pads the destination buffer and therefore
avoids writing to it twice.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20251119135217.233084-1-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Thorsten Blum 2025-11-19 14:52:17 +01:00 committed by Takashi Iwai
parent 18a4895370
commit ad5f82ab04
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/drivers/pcmtest.c
View File

@ -696,10 +696,10 @@ static int setup_patt_bufs(void)
size_t i; size_t i;
for (i = 0; i < ARRAY_SIZE(patt_bufs); i++) { for (i = 0; i < ARRAY_SIZE(patt_bufs); i++) {
patt_bufs[i].buf = kzalloc(MAX_PATTERN_LEN, GFP_KERNEL); patt_bufs[i].buf = kmalloc(MAX_PATTERN_LEN, GFP_KERNEL);
if (!patt_bufs[i].buf) if (!patt_bufs[i].buf)
break; break;
strcpy(patt_bufs[i].buf, DEFAULT_PATTERN); strscpy_pad(patt_bufs[i].buf, DEFAULT_PATTERN, MAX_PATTERN_LEN);
patt_bufs[i].len = DEFAULT_PATTERN_LEN; patt_bufs[i].len = DEFAULT_PATTERN_LEN;
} }