Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mempool: legitimize the io_schedule_timeout in mempool_alloc_from_pool 

The timeout here is and old workaround with a Fixme comment.  But
thinking about it, it makes sense to keep it, so reword the comment.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/20251113084022.1255121-9-hch@lst.de
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
This commit is contained in:
Christoph Hellwig 2025-11-13 09:39:49 +01:00 committed by Vlastimil Babka
parent ac529d86ad
commit 9c4391767f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mm/mempool.c
View File

@ -427,10 +427,10 @@ static unsigned int mempool_alloc_from_pool(struct mempool *pool, void **elems,
spin_unlock_irqrestore(&pool->lock, flags);
/*
* Wait for someone else to return an element to @pool.
*
* FIXME: this should be io_schedule(). The timeout is there as
* a workaround for some DM problems in 2.6.18.
* Wait for someone else to return an element to @pool, but wake
* up occasionally as memory pressure might have reduced even
* and the normal allocation in alloc_fn could succeed even if
* no element was returned.
*/
io_schedule_timeout(5 * HZ);
finish_wait(&pool->wait, &wait);