Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hwmon/lm78: Drop REALLY_SLOW_IO setting 

In lm78_isa_found() there is REALLY_SLOW_IO defined around some port
accesses, probably in order to wait between multiple accesses.

Unfortunately this isn't making any difference compared to not having
this define since more than a decade, as REALLY_SLOW_IO needs to be
defined while "#include <asm/io.h>" is called to have an effect.

As there seem not to be any outstanding issues in spite of this having
no effect, just drop the "#define" and add a remark to the related
comment.

Signed-off-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20251126162018.5676-3-jgross@suse.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Juergen Gross 2025-11-26 17:20:15 +01:00 committed by Guenter Roeck
parent 2f88425ef5
commit 8ac2a19d70
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hwmon/lm78.c
View File

@ -843,17 +843,18 @@ static int __init lm78_isa_found(unsigned short address)
} }
} }
#define REALLY_SLOW_IO
/* /*
* We need the timeouts for at least some LM78-like * We need the timeouts for at least some LM78-like
* chips. But only if we read 'undefined' registers. * chips. But only if we read 'undefined' registers.
* There used to be a "#define REALLY_SLOW_IO" to enforce that, but
* this has been without any effect since more than a decade, so it
* has been dropped.
*/ */
val = inb_p(address + 1); val = inb_p(address + 1);
if (inb_p(address + 2) != val if (inb_p(address + 2) != val
|| inb_p(address + 3) != val || inb_p(address + 3) != val
|| inb_p(address + 7) != val) || inb_p(address + 7) != val)
goto release; goto release;
#undef REALLY_SLOW_IO
/* /*
* We should be able to change the 7 LSB of the address port. The * We should be able to change the 7 LSB of the address port. The