Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

usbip: Correct format specifier for seqnum from %d to %u 

The seqnum field in USBIP protocol is an unsigned value.
So we fix the format specifier from %d to %u to correctly
display the value.

Signed-off-by: Xiong Nandi <xndchn@gmail.com>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20241231161539.20192-3-xndchn@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Xiong Nandi 2025-01-01 00:15:38 +08:00 committed by Greg Kroah-Hartman
parent 15b93f340f
commit 81702d4145
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/usbip/stub_rx.c
View File

@ -269,7 +269,7 @@ static int stub_recv_cmd_unlink(struct stub_device *sdev,
return 0; return 0;
} }
usbip_dbg_stub_rx("seqnum %d is not pending\n", usbip_dbg_stub_rx("seqnum %u is not pending\n",
pdu->u.cmd_unlink.seqnum); pdu->u.cmd_unlink.seqnum);
/* /*

2
drivers/usb/usbip/stub_tx.c
View File

@ -201,7 +201,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
/* 1. setup usbip_header */ /* 1. setup usbip_header */
setup_ret_submit_pdu(&pdu_header, urb); setup_ret_submit_pdu(&pdu_header, urb);
usbip_dbg_stub_tx("setup txdata seqnum: %d\n", usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
pdu_header.base.seqnum); pdu_header.base.seqnum);
if (priv->sgl) { if (priv->sgl) {

6
drivers/usb/usbip/vhci_rx.c
View File

@ -66,7 +66,7 @@ static void vhci_recv_ret_submit(struct vhci_device *vdev,
spin_unlock_irqrestore(&vdev->priv_lock, flags); spin_unlock_irqrestore(&vdev->priv_lock, flags);
if (!urb) { if (!urb) {
pr_err("cannot find a urb of seqnum %u max seqnum %d\n", pr_err("cannot find a urb of seqnum %u max seqnum %u\n",
pdu->base.seqnum, pdu->base.seqnum,
atomic_read(&vhci_hcd->seqnum)); atomic_read(&vhci_hcd->seqnum));
usbip_event_add(ud, VDEV_EVENT_ERROR_TCP); usbip_event_add(ud, VDEV_EVENT_ERROR_TCP);
@ -162,10 +162,10 @@ static void vhci_recv_ret_unlink(struct vhci_device *vdev,
* already received the result of its submit result and gave * already received the result of its submit result and gave
* back the URB. * back the URB.
*/ */
pr_info("the urb (seqnum %d) was already given back\n", pr_info("the urb (seqnum %u) was already given back\n",
pdu->base.seqnum); pdu->base.seqnum);
} else { } else {
usbip_dbg_vhci_rx("now giveback urb %d\n", pdu->base.seqnum); usbip_dbg_vhci_rx("now giveback urb %u\n", pdu->base.seqnum);
/* If unlink is successful, status is -ECONNRESET */ /* If unlink is successful, status is -ECONNRESET */
urb->status = pdu->u.ret_unlink.status; urb->status = pdu->u.ret_unlink.status;

2
drivers/usb/usbip/vudc_tx.c
View File

@ -107,7 +107,7 @@ static int v_send_ret_submit(struct vudc *udc, struct urbp *urb_p)
/* 1. setup usbip_header */ /* 1. setup usbip_header */
setup_ret_submit_pdu(&pdu_header, urb_p); setup_ret_submit_pdu(&pdu_header, urb_p);
usbip_dbg_stub_tx("setup txdata seqnum: %d\n", usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
pdu_header.base.seqnum); pdu_header.base.seqnum);
usbip_header_correct_endian(&pdu_header, 1); usbip_header_correct_endian(&pdu_header, 1);