Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iomap: adjust read range correctly for non-block-aligned positions 

iomap_adjust_read_range() assumes that the position and length passed in
are block-aligned. This is not always the case however, as shown in the
syzbot generated case for erofs. This causes too many bytes to be
skipped for uptodate blocks, which results in returning the incorrect
position and length to read in. If all the blocks are uptodate, this
underflows length and returns a position beyond the folio.

Fix the calculation to also take into account the block offset when
calculating how many bytes can be skipped for uptodate blocks.

Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
Tested-by: syzbot@syzkaller.appspotmail.com
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Joanne Koong 2025-09-22 11:00:42 -07:00 committed by Christian Brauner
parent ca82a7ea22
commit 7aa6bc3e87
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
fs/iomap/buffered-io.c
View File

@ -240,17 +240,24 @@ static void iomap_adjust_read_range(struct inode *inode, struct folio *folio,
* to avoid reading in already uptodate ranges. * to avoid reading in already uptodate ranges.
*/ */
if (ifs) { if (ifs) {
unsigned int i; unsigned int i, blocks_skipped;
/* move forward for each leading block marked uptodate */ /* move forward for each leading block marked uptodate */
for (i = first; i <= last; i++) { for (i = first; i <= last; i++)
if (!ifs_block_is_uptodate(ifs, i)) if (!ifs_block_is_uptodate(ifs, i))
break; break;
*pos += block_size;
poff += block_size; blocks_skipped = i - first;
plen -= block_size; if (blocks_skipped) {
first++; unsigned long block_offset = *pos & (block_size - 1);
unsigned bytes_skipped =
(blocks_skipped << block_bits) - block_offset;
*pos += bytes_skipped;
poff += bytes_skipped;
plen -= bytes_skipped;
} }
first = i;
/* truncate len if we find any trailing uptodate block(s) */ /* truncate len if we find any trailing uptodate block(s) */
while (++i <= last) { while (++i <= last) {