Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto: asymmetric_keys - fix uninitialized pointers with free attribute 

Uninitialized pointers with `__free` attribute can cause undefined
behavior as the memory assigned randomly to the pointer is freed
automatically when the pointer goes out of scope.

crypto/asymmetric_keys doesn't have any bugs related to this as of now,
but, it is better to initialize and assign pointers with `__free`
attribute in one statement to ensure proper scope-based cleanup

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/
Signed-off-by: Ally Heev <allyheev@gmail.com>
Reviewed-by: Ignat Korchagin <ignat@cloudflare.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Ally Heev 2025-11-11 19:06:29 +05:30 committed by Herbert Xu
parent a26c23e0d6
commit 79492d5adf
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crypto/asymmetric_keys/x509_cert_parser.c
View File

@ -60,7 +60,7 @@ EXPORT_SYMBOL_GPL(x509_free_certificate);
*/ */
struct x509_certificate *x509_cert_parse(const void *data, size_t datalen) struct x509_certificate *x509_cert_parse(const void *data, size_t datalen)
{ {
struct x509_certificate *cert __free(x509_free_certificate); struct x509_certificate *cert __free(x509_free_certificate) = NULL;
struct x509_parse_context *ctx __free(kfree) = NULL; struct x509_parse_context *ctx __free(kfree) = NULL;
struct asymmetric_key_id *kid; struct asymmetric_key_id *kid;
long ret; long ret;

2
crypto/asymmetric_keys/x509_public_key.c
View File

@ -148,7 +148,7 @@ int x509_check_for_self_signed(struct x509_certificate *cert)
*/ */
static int x509_key_preparse(struct key_preparsed_payload *prep) static int x509_key_preparse(struct key_preparsed_payload *prep)
{ {
struct x509_certificate *cert __free(x509_free_certificate); struct x509_certificate *cert __free(x509_free_certificate) = NULL;
struct asymmetric_key_ids *kids __free(kfree) = NULL; struct asymmetric_key_ids *kids __free(kfree) = NULL;
char *p, *desc __free(kfree) = NULL; char *p, *desc __free(kfree) = NULL;
const char *q; const char *q;