Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

driver core: module: make module_[add|remove]_driver take a const * 

The functions module_add_driver() and module_remove_driver() do not
modify the struct device_driver structure directly, so they are safe to
be marked as a constant pointer type.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/2024070850-entering-grandson-205e@gregkh
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2024-07-08 10:15:47 +02:00
parent f8fb469147
commit 67c1ba551e
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/base/base.h
View File

@ -192,8 +192,8 @@ extern struct kset *devices_kset;
void devices_kset_move_last(struct device *dev); void devices_kset_move_last(struct device *dev);
#if defined(CONFIG_MODULES) && defined(CONFIG_SYSFS) #if defined(CONFIG_MODULES) && defined(CONFIG_SYSFS)
int module_add_driver(struct module *mod, struct device_driver *drv); int module_add_driver(struct module *mod, const struct device_driver *drv);
void module_remove_driver(struct device_driver *drv); void module_remove_driver(const struct device_driver *drv);
#else #else
static inline int module_add_driver(struct module *mod, static inline int module_add_driver(struct module *mod,
struct device_driver *drv) struct device_driver *drv)

6
drivers/base/module.c
View File

@ -9,7 +9,7 @@
#include <linux/string.h> #include <linux/string.h>
#include "base.h" #include "base.h"
static char *make_driver_name(struct device_driver *drv) static char *make_driver_name(const struct device_driver *drv)
{ {
char *driver_name; char *driver_name;
@ -30,7 +30,7 @@ static void module_create_drivers_dir(struct module_kobject *mk)
mutex_unlock(&drivers_dir_mutex); mutex_unlock(&drivers_dir_mutex);
} }
int module_add_driver(struct module *mod, struct device_driver *drv) int module_add_driver(struct module *mod, const struct device_driver *drv)
{ {
char *driver_name; char *driver_name;
struct module_kobject *mk = NULL; struct module_kobject *mk = NULL;
@ -89,7 +89,7 @@ int module_add_driver(struct module *mod, struct device_driver *drv)
return ret; return ret;
} }
void module_remove_driver(struct device_driver *drv) void module_remove_driver(const struct device_driver *drv)
{ {
struct module_kobject *mk = NULL; struct module_kobject *mk = NULL;
char *driver_name; char *driver_name;