Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spi: Add TODO comment about ACPI GPIO setup 

Add a TODO comment that ideally the ACPI/gpiolib core code should take care
of setting GPIO direction and/or bias according to ACPI GPIO resources.

If this TODO gets implemented then the acpi_dev_gpio_irq_get() call in
acpi_register_spi_device() can be dropped.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://patch.msgid.link/20251109155340.26199-1-johannes.goede@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Hans de Goede 2025-11-09 16:53:39 +01:00 committed by Mark Brown
parent 939edfaa10
commit 66e9feb03e
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/spi/spi.c
View File

@ -2857,6 +2857,8 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr,
* here too, because this call sets the GPIO direction and/or bias. * here too, because this call sets the GPIO direction and/or bias.
* Setting these needs to be done even if there is no driver, in which * Setting these needs to be done even if there is no driver, in which
* case spi_probe() will never get called. * case spi_probe() will never get called.
* TODO: ideally the setup of the GPIO should be handled in a generic
* manner in the ACPI/gpiolib core code.
*/ */
if (spi->irq < 0) if (spi->irq < 0)
spi->irq = acpi_dev_gpio_irq_get(adev, 0); spi->irq = acpi_dev_gpio_irq_get(adev, 0);