RAS/AMD/ATL: Return error codes from helper functions

Pass up error codes from helper functions rather than discarding them.

Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
This commit is contained in:
Yazen Ghannam 2025-10-06 15:10:27 +00:00 committed by Borislav Petkov (AMD)
parent 3a86608788
commit 6553c68bc7
2 changed files with 10 additions and 4 deletions

View File

@ -194,6 +194,8 @@ MODULE_DEVICE_TABLE(x86cpu, amd_atl_cpuids);
static int __init amd_atl_init(void)
{
int ret;
if (!x86_match_cpu(amd_atl_cpuids))
return -ENODEV;
@ -202,8 +204,9 @@ static int __init amd_atl_init(void)
check_for_legacy_df_access();
if (get_df_system_info())
return -ENODEV;
ret = get_df_system_info();
if (ret)
return ret;
/* Increment this module's recount so that it can't be easily unloaded. */
__module_get(THIS_MODULE);

View File

@ -288,10 +288,13 @@ static void dump_df_cfg(void)
int get_df_system_info(void)
{
if (determine_df_rev()) {
int ret;
ret = determine_df_rev();
if (ret) {
pr_warn("Failed to determine DF Revision");
df_cfg.rev = UNKNOWN;
return -EINVAL;
return ret;
}
apply_node_id_shift();