Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pwm: atmel: Drop driver local locking 

The two functions making use of the lock are only called transitively from
.apply(). Calls to .apply() are already serialized by the pwm core so the
lock in the driver has no effect and can safely be dropped.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/5ad3417aecd4dc6eca9699e21691e3725ea0bb87.1750788649.git.u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
This commit is contained in:
Uwe Kleine-König 2025-06-24 20:15:37 +02:00 committed by Uwe Kleine-König
parent 0191c80e8a
commit 62df49917e
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/pwm/pwm-atmel.c
View File

@ -91,9 +91,6 @@ struct atmel_pwm_chip {
* hardware. * hardware.
*/ */
u32 update_pending; u32 update_pending;
/* Protects .update_pending */
spinlock_t lock;
}; };
static inline struct atmel_pwm_chip *to_atmel_pwm_chip(struct pwm_chip *chip) static inline struct atmel_pwm_chip *to_atmel_pwm_chip(struct pwm_chip *chip)
@ -145,8 +142,6 @@ static void atmel_pwm_update_pending(struct atmel_pwm_chip *chip)
static void atmel_pwm_set_pending(struct atmel_pwm_chip *chip, unsigned int ch) static void atmel_pwm_set_pending(struct atmel_pwm_chip *chip, unsigned int ch)
{ {
spin_lock(&chip->lock);
/* /*
* Clear pending flags in hardware because otherwise there might still * Clear pending flags in hardware because otherwise there might still
* be a stale flag in ISR. * be a stale flag in ISR.
@ -154,16 +149,12 @@ static void atmel_pwm_set_pending(struct atmel_pwm_chip *chip, unsigned int ch)
atmel_pwm_update_pending(chip); atmel_pwm_update_pending(chip);
chip->update_pending |= (1 << ch); chip->update_pending |= (1 << ch);
spin_unlock(&chip->lock);
} }
static int atmel_pwm_test_pending(struct atmel_pwm_chip *chip, unsigned int ch) static int atmel_pwm_test_pending(struct atmel_pwm_chip *chip, unsigned int ch)
{ {
int ret = 0; int ret = 0;
spin_lock(&chip->lock);
if (chip->update_pending & (1 << ch)) { if (chip->update_pending & (1 << ch)) {
atmel_pwm_update_pending(chip); atmel_pwm_update_pending(chip);
@ -171,8 +162,6 @@ static int atmel_pwm_test_pending(struct atmel_pwm_chip *chip, unsigned int ch)
ret = 1; ret = 1;
} }
spin_unlock(&chip->lock);
return ret; return ret;
} }
@ -509,7 +498,6 @@ static int atmel_pwm_probe(struct platform_device *pdev)
atmel_pwm->data = of_device_get_match_data(&pdev->dev); atmel_pwm->data = of_device_get_match_data(&pdev->dev);
atmel_pwm->update_pending = 0; atmel_pwm->update_pending = 0;
spin_lock_init(&atmel_pwm->lock);
atmel_pwm->base = devm_platform_ioremap_resource(pdev, 0); atmel_pwm->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(atmel_pwm->base)) if (IS_ERR(atmel_pwm->base))