Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drivers,cxl: use node-notifier instead of memory-notifier 

memory-tier is only concerned when a numa node changes its memory state,
specifically when a numa node with memory comes into play for the first
time, because it needs to get its performance attributes to build a proper
demotion chain.  So stop using the memory notifier and use the new numa
node notifer instead.

Link: https://lkml.kernel.org/r/20250616135158.450136-7-osalvador@suse.de
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Rakie Kim <rakie.kim@sk.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Oscar Salvador 2025-06-16 15:51:49 +02:00 committed by Andrew Morton
parent 265ab08697
commit 41a9344bb7
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/cxl/core/region.c
View File

@ -2451,12 +2451,12 @@ static int cxl_region_perf_attrs_callback(struct notifier_block *nb,
unsigned long action, void *arg) unsigned long action, void *arg)
{ {
struct cxl_region *cxlr = container_of(nb, struct cxl_region, struct cxl_region *cxlr = container_of(nb, struct cxl_region,
memory_notifier); node_notifier);
struct memory_notify *mnb = arg; struct node_notify *nn = arg;
int nid = mnb->status_change_nid; int nid = nn->nid;
int region_nid; int region_nid;
if (nid == NUMA_NO_NODE || action != MEM_ONLINE) if (action != NODE_ADDED_FIRST_MEMORY)
return NOTIFY_DONE; return NOTIFY_DONE;
/* /*
@ -3527,7 +3527,7 @@ static void shutdown_notifiers(void *_cxlr)
{ {
struct cxl_region *cxlr = _cxlr; struct cxl_region *cxlr = _cxlr;
unregister_memory_notifier(&cxlr->memory_notifier); unregister_node_notifier(&cxlr->node_notifier);
unregister_mt_adistance_algorithm(&cxlr->adist_notifier); unregister_mt_adistance_algorithm(&cxlr->adist_notifier);
} }
@ -3566,9 +3566,9 @@ static int cxl_region_probe(struct device *dev)
if (rc) if (rc)
return rc; return rc;
cxlr->memory_notifier.notifier_call = cxl_region_perf_attrs_callback; cxlr->node_notifier.notifier_call = cxl_region_perf_attrs_callback;
cxlr->memory_notifier.priority = CXL_CALLBACK_PRI; cxlr->node_notifier.priority = CXL_CALLBACK_PRI;
register_memory_notifier(&cxlr->memory_notifier); register_node_notifier(&cxlr->node_notifier);
cxlr->adist_notifier.notifier_call = cxl_region_calculate_adistance; cxlr->adist_notifier.notifier_call = cxl_region_calculate_adistance;
cxlr->adist_notifier.priority = 100; cxlr->adist_notifier.priority = 100;

4
drivers/cxl/cxl.h
View File

@ -513,7 +513,7 @@ enum cxl_partition_mode {
* @flags: Region state flags * @flags: Region state flags
* @params: active + config params for the region * @params: active + config params for the region
* @coord: QoS access coordinates for the region * @coord: QoS access coordinates for the region
* @memory_notifier: notifier for setting the access coordinates to node * @node_notifier: notifier for setting the access coordinates to node
* @adist_notifier: notifier for calculating the abstract distance of node * @adist_notifier: notifier for calculating the abstract distance of node
*/ */
struct cxl_region { struct cxl_region {
@ -526,7 +526,7 @@ struct cxl_region {
unsigned long flags; unsigned long flags;
struct cxl_region_params params; struct cxl_region_params params;
struct access_coordinate coord[ACCESS_COORDINATE_MAX]; struct access_coordinate coord[ACCESS_COORDINATE_MAX];
struct notifier_block memory_notifier; struct notifier_block node_notifier;
struct notifier_block adist_notifier; struct notifier_block adist_notifier;
}; };