Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hwmon: (ina238) Rely on subsystem locking 

Attribute access is now serialized in the hardware monitoring core,
so locking in the driver code is no longer necessary. Drop it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2025-09-07 11:44:37 -07:00
parent fa035d98db
commit 3da03e4e0e
1 changed files with 5 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/hwmon/ina238.c
View File

@ -117,7 +117,6 @@ struct ina238_config {
struct ina238_data { struct ina238_data {
const struct ina238_config *config; const struct ina238_config *config;
struct i2c_client *client; struct i2c_client *client;
struct mutex config_lock;
struct regmap *regmap; struct regmap *regmap;
u32 rshunt; u32 rshunt;
int gain; int gain;
@ -607,31 +606,18 @@ static int ina238_read(struct device *dev, enum hwmon_sensor_types type,
static int ina238_write(struct device *dev, enum hwmon_sensor_types type, static int ina238_write(struct device *dev, enum hwmon_sensor_types type,
u32 attr, int channel, long val) u32 attr, int channel, long val)
{ {
struct ina238_data *data = dev_get_drvdata(dev);
int err;
mutex_lock(&data->config_lock);
switch (type) { switch (type) {
case hwmon_in: case hwmon_in:
err = ina238_write_in(dev, attr, channel, val); return ina238_write_in(dev, attr, channel, val);
break;
case hwmon_curr: case hwmon_curr:
err = ina238_write_curr(dev, attr, val); return ina238_write_curr(dev, attr, val);
break;
case hwmon_power: case hwmon_power:
err = ina238_write_power_max(dev, val); return ina238_write_power_max(dev, val);
break;
case hwmon_temp: case hwmon_temp:
err = ina238_write_temp_max(dev, val); return ina238_write_temp_max(dev, val);
break;
default: default:
err = -EOPNOTSUPP; return -EOPNOTSUPP;
break;
} }
mutex_unlock(&data->config_lock);
return err;
} }
static umode_t ina238_is_visible(const void *drvdata, static umode_t ina238_is_visible(const void *drvdata,
@ -757,8 +743,6 @@ static int ina238_probe(struct i2c_client *client)
/* set the device type */ /* set the device type */
data->config = &ina238_config[chip]; data->config = &ina238_config[chip];
mutex_init(&data->config_lock);
data->regmap = devm_regmap_init_i2c(client, &ina238_regmap_config); data->regmap = devm_regmap_init_i2c(client, &ina238_regmap_config);
if (IS_ERR(data->regmap)) { if (IS_ERR(data->regmap)) {
dev_err(dev, "failed to allocate register map\n"); dev_err(dev, "failed to allocate register map\n");