Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hwmon: (tmp401) Rely on subsystem locking 

Attribute access is now serialized in the hardware monitoring core,
so locking in the driver code is no longer necessary. Drop it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2025-06-07 21:01:11 -07:00
parent dc11f797b1
commit 3c1aefb365
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/hwmon/tmp401.c
View File

@ -24,7 +24,6 @@
#include <linux/hwmon.h> #include <linux/hwmon.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/mutex.h>
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/slab.h> #include <linux/slab.h>
@ -107,7 +106,6 @@ MODULE_DEVICE_TABLE(i2c, tmp401_id);
struct tmp401_data { struct tmp401_data {
struct i2c_client *client; struct i2c_client *client;
struct regmap *regmap; struct regmap *regmap;
struct mutex update_lock;
enum chips kind; enum chips kind;
bool extended_range; bool extended_range;
@ -357,7 +355,6 @@ static int tmp401_temp_write(struct device *dev, u32 attr, int channel,
unsigned int regval; unsigned int regval;
int reg, ret, temp; int reg, ret, temp;
mutex_lock(&data->update_lock);
switch (attr) { switch (attr) {
case hwmon_temp_min: case hwmon_temp_min:
case hwmon_temp_max: case hwmon_temp_max:
@ -386,7 +383,6 @@ static int tmp401_temp_write(struct device *dev, u32 attr, int channel,
ret = -EOPNOTSUPP; ret = -EOPNOTSUPP;
break; break;
} }
mutex_unlock(&data->update_lock);
return ret; return ret;
} }
@ -436,7 +432,6 @@ static int tmp401_chip_write(struct device *dev, u32 attr, int channel, long val
struct regmap *regmap = data->regmap; struct regmap *regmap = data->regmap;
int err; int err;
mutex_lock(&data->update_lock);
switch (attr) { switch (attr) {
case hwmon_chip_update_interval: case hwmon_chip_update_interval:
err = tmp401_set_convrate(regmap, val); err = tmp401_set_convrate(regmap, val);
@ -456,8 +451,6 @@ static int tmp401_chip_write(struct device *dev, u32 attr, int channel, long val
err = -EOPNOTSUPP; err = -EOPNOTSUPP;
break; break;
} }
mutex_unlock(&data->update_lock);
return err; return err;
} }
@ -685,7 +678,6 @@ static int tmp401_probe(struct i2c_client *client)
return -ENOMEM; return -ENOMEM;
data->client = client; data->client = client;
mutex_init(&data->update_lock);
data->kind = (uintptr_t)i2c_get_match_data(client); data->kind = (uintptr_t)i2c_get_match_data(client);
data->regmap = devm_regmap_init(dev, NULL, data, &tmp401_regmap_config); data->regmap = devm_regmap_init(dev, NULL, data, &tmp401_regmap_config);