Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PM / devfreq: hisi: Fix potential UAF in OPP handling 

Ensure all required data is acquired before calling dev_pm_opp_put(opp)
to maintain correct resource acquisition and release order.

Fixes: 7da2fdaaa1 ("PM / devfreq: Add HiSilicon uncore frequency scaling driver")
Signed-off-by: Pengjie Zhang <zhangpengjie2@huawei.com>
Reviewed-by: Jie Zhan <zhanjie9@hisilicon.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Link: https://patchwork.kernel.org/project/linux-pm/patch/20250915062135.748653-1-zhangpengjie2@huawei.com/
This commit is contained in:
Pengjie Zhang 2025-09-15 14:21:35 +08:00 committed by Chanwoo Choi
parent 447c4e8338
commit 26dd44a400
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/devfreq/hisi_uncore_freq.c
View File

@ -264,10 +264,11 @@ static int hisi_uncore_target(struct device *dev, unsigned long *freq,
dev_err(dev, "Failed to get opp for freq %lu hz\n", *freq); dev_err(dev, "Failed to get opp for freq %lu hz\n", *freq);
return PTR_ERR(opp); return PTR_ERR(opp);
} }
dev_pm_opp_put(opp);
data = (u32)(dev_pm_opp_get_freq(opp) / HZ_PER_MHZ); data = (u32)(dev_pm_opp_get_freq(opp) / HZ_PER_MHZ);
dev_pm_opp_put(opp);
return hisi_uncore_cmd_send(uncore, HUCF_PCC_CMD_SET_FREQ, &data); return hisi_uncore_cmd_send(uncore, HUCF_PCC_CMD_SET_FREQ, &data);
} }