Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

genksyms: refactor the return points in the for-loop in __add_symbol() 

free_list() must be called before returning from this for-loop.

Swap 'break' and the combination of free_list() and 'return'.

This reduces the code and minimizes the risk of introducing memory
leaks in future changes.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada 2025-01-03 16:30:41 +09:00
parent f034d186bf
commit 2480f53f21
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/genksyms/genksyms.c
View File

@ -231,7 +231,7 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type,
continue; continue;
if (is_reference) { if (is_reference) {
/* fall through */ ; break;
} else if (sym->type == type && equal_list(sym->defn, defn)) { } else if (sym->type == type && equal_list(sym->defn, defn)) {
if (!sym->is_declared && sym->is_override) { if (!sym->is_declared && sym->is_override) {
print_location(); print_location();
@ -239,25 +239,21 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type,
fprintf(stderr, " modversion is unchanged\n"); fprintf(stderr, " modversion is unchanged\n");
} }
sym->is_declared = 1; sym->is_declared = 1;
free_list(defn, NULL);
return sym;
} else if (sym->is_declared) { } else if (sym->is_declared) {
error_with_pos("redefinition of %s", name); error_with_pos("redefinition of %s", name);
free_list(defn, NULL);
return sym;
} else if (sym->is_override && flag_preserve) { } else if (sym->is_override && flag_preserve) {
print_location(); print_location();
fprintf(stderr, "ignoring "); fprintf(stderr, "ignoring ");
print_type_name(type, name); print_type_name(type, name);
fprintf(stderr, " modversion change\n"); fprintf(stderr, " modversion change\n");
sym->is_declared = 1; sym->is_declared = 1;
free_list(defn, NULL);
return sym;
} else { } else {
status = is_unknown_symbol(sym) ? status = is_unknown_symbol(sym) ?
STATUS_DEFINED : STATUS_MODIFIED; STATUS_DEFINED : STATUS_MODIFIED;
break;
} }
break; free_list(defn, NULL);
return sym;
} }
if (sym) { if (sym) {