Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: PM: Fix reverse check in filesystems_freeze_callback() 

The freeze_all_ptr check in filesystems_freeze_callback() introduced by
commit a3f8f86627 ("power: always freeze efivarfs") is reverse which
quite confusingly causes all file systems to be frozen when
filesystem_freeze_enabled is false.

On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to
trigger, most likely due to an attempt to freeze a file system that is
not ready for that.

Add a logical negation to the check in question to reverse it as
appropriate.

Fixes: a3f8f86627 ("power: always freeze efivarfs")
Cc: 6.18+ <stable@vger.kernel.org> # 6.18+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/12788397.O9o76ZdvQC@rafael.j.wysocki
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Rafael J. Wysocki 2025-12-02 19:27:29 +01:00 committed by Christian Brauner
parent 3f9f025213
commit 222047f68e
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/super.c
View File

@ -1189,7 +1189,7 @@ static void filesystems_freeze_callback(struct super_block *sb, void *freeze_all
if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super) if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super)
return; return;
if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE)) if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
return; return;
if (!get_active_super(sb)) if (!get_active_super(sb))