Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

s390/ptdump: Use seq_puts() in pt_dump_seq_puts() macro 

The pt_dump_seq_puts() macro incorrectly uses seq_printf() instead of
seq_puts(). This is both a performance issue and conceptually wrong,
as the macro name suggests plain string output (puts) but the
implementation uses formatted output (printf).

The macro is used in dump_pagetables.c:67-68 and 131 to output
constant strings. Using seq_printf() adds unnecessary overhead for
format string parsing.

Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
This commit is contained in:
Josephine Pfeiffer 2025-10-18 19:05:21 +02:00 committed by Heiko Carstens
parent 5e09c0a03e
commit 215231deea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/s390/mm/dump_pagetables.c
View File

@ -51,7 +51,7 @@ struct pg_state {
struct seq_file *__m = (m); \ struct seq_file *__m = (m); \
\ \
if (__m) \ if (__m) \
seq_printf(__m, fmt); \ seq_puts(__m, fmt); \
}) })
static void print_prot(struct seq_file *m, unsigned int pr, int level) static void print_prot(struct seq_file *m, unsigned int pr, int level)