Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dma-debug: remove DMA_API_DEBUG_SG 

The scatterlist validity checks are pretty simple and cheap, perform them
unconditionally.

Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Christoph Hellwig 2024-10-15 10:29:20 +02:00
parent 9d4f645a1f
commit 150745b49a
2 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
kernel/dma/Kconfig
View File

@ -260,23 +260,6 @@ config DMA_API_DEBUG
If unsure, say N. If unsure, say N.
config DMA_API_DEBUG_SG
bool "Debug DMA scatter-gather usage"
default y
depends on DMA_API_DEBUG
help
Perform extra checking that callers of dma_map_sg() have respected the
appropriate segment length/boundary limits for the given device when
preparing DMA scatterlists.
This is particularly likely to have been overlooked in cases where the
dma_map_sg() API is used for general bulk mapping of pages rather than
preparing literal scatter-gather descriptors, where there is a risk of
unexpected behaviour from DMA API implementations if the scatterlist
is technically out-of-spec.
If unsure, say N.
config DMA_MAP_BENCHMARK config DMA_MAP_BENCHMARK
bool "Enable benchmarking of streaming DMA mapping" bool "Enable benchmarking of streaming DMA mapping"
depends on DEBUG_FS depends on DEBUG_FS

2
kernel/dma/debug.c
View File

@ -1163,7 +1163,6 @@ static void check_sync(struct device *dev,
static void check_sg_segment(struct device *dev, struct scatterlist *sg) static void check_sg_segment(struct device *dev, struct scatterlist *sg)
{ {
#ifdef CONFIG_DMA_API_DEBUG_SG
unsigned int max_seg = dma_get_max_seg_size(dev); unsigned int max_seg = dma_get_max_seg_size(dev);
u64 start, end, boundary = dma_get_seg_boundary(dev); u64 start, end, boundary = dma_get_seg_boundary(dev);
@ -1184,7 +1183,6 @@ static void check_sg_segment(struct device *dev, struct scatterlist *sg)
if ((start ^ end) & ~boundary) if ((start ^ end) & ~boundary)
err_printk(dev, NULL, "mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n", err_printk(dev, NULL, "mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
start, end, boundary); start, end, boundary);
#endif
} }
void debug_dma_map_single(struct device *dev, const void *addr, void debug_dma_map_single(struct device *dev, const void *addr,